Closed Bug 1736047 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31269 - [css] Fix intrinsic sizes invalidation for images with % max-height

Categories

(Core :: Layout: Flexbox, task, P4)

Product:
Core
Component:
Layout: Flexbox
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31269 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31269
Details from upstream follow.

David Grogan <dgrogan@chromium.org> wrote:

[css] Fix intrinsic sizes invalidation for images with % max-height

Previously we would reuse cached inline sizes for an image with
%max-height even when the parent height would change. This led to
trouble for cases like

\<div style="height: 100px;" id=outer>
\<img src=300x300.png style="max-height: 100%">
\</div>
outer.style.height = 200px;

The img's intrinsic width was still 100px, even after script changed it
to 200px.

This cache invalidation was already working for elements with a
specified aspect ratio but not for replaced elements with a natural
aspect ratio.

Fixed: 1256802
Change-Id: I6c21fdf9c7fa0795dcf0100f3b37665910cf9cb9

Reviewed-on: https://chromium-review.googlesource.com/3226479
WPT-Export-Revision: d766a3efc9d64d2ee3b9fae0f6dcf6aa5b5b8a9e

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core
Test result changes from PR not available.
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/03aff2ff5f1f
[wpt PR 31269] - [css] Fix intrinsic sizes invalidation for images with % max-height, a=testonly

https://hg.mozilla.org/mozilla-central/rev/03aff2ff5f1f

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.