1736093 - Cancelling the "Party Crashing" dialog should not add event to calendar.

Status: RESOLVED FIXED

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Description

[Lasana Murray]

Cancelling this dialog still adds the event to the calendar resulting in an event with a missing "invited attendee" thus causing the event to be treated like a regular event and not an invitation. Instead we should skip adding the event if the user chooses not to select an identity.

Comment 1

[Magnus Melin [:mkmelin]]

Not sure that's reasonable. Like I commented on the the related patch, you may have already selected which calendar it should be added to.

Comment 2

[Lasana Murray]

(In reply to Magnus Melin [:mkmelin] from comment #1)

Not sure that's reasonable. Like I commented on the the related patch, you may have already selected which calendar it should be added to.

As it is right now, the invitation will have the wrong UI controls and will be editable by the user. The whole workflow around the calendar's identity needs to be revised but we are not there yet.

Comment 3

[Lasana Murray]

Attachment: Bug 1736093 - Do not add event to calendar if user cancels party crashing dialog. r=darktrojan

Comment 4

[Lasana Murray]

Attachment: Bug 1736093 - Prompt user about "Party Crashing" earlier in the itip workflow. r=darktrojan

This patch also ensures that cancel the dialog at anytime aborts the whole process.
The dialog is also now sorted so that the identity that actually received the invitation
if offered first.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/67e9a5fdb0ee
Prompt user about "Party Crashing" earlier in the itip workflow. r=darktrojan

Comment 6

[Lasana Murray]

Better to not uplift this, there is an issue in this patch later fixed and we don't have enough tests yet in this area to detect other problems.