173623 - Send external installer progress updates on a per-file basis, not per-archive basis

Status: RESOLVED WONTFIX

(Core Graveyard :: Installer: GRE, defect)

Description

[[e-mail] (away - not reading bugmail)]

This is a follow-up work item to bug 168139. We need to change xpi.c to provide
more frequent progress updates once work on bug 173615 has been completed.

Comment 1

[[e-mail] (away - not reading bugmail)]

Attachment: functional patch

I've tested this extensively in my private build, it seems to satisfy all
functional requirements.

Comment 2

[[e-mail] (away - not reading bugmail)]

I found one potential issue; when running GRE installer with the "-ms" option,
we are not displaying any UI and are not making callbacks to cbXPIProgress(),
where external installer progress updates are issued.

We might want to consider a separate GRE progress update callback function,
should the "-ms" option become a requirement for GRE intergrators.

Comment 3

[Curt Patrick (gone)]

The -ms option or its equivalent will certainly be a requirement for integrating
the gre installer into client installers.  Mfcembed gets by without it because
both it and the gre have the same Mozilla UI.  This isn't going to work for
other client installers, I'm sure.  Better keep this bug open until we have a
solution for this.

Comment 4

[Sean Su]

jbetak and curt had mentioned to me that it was already done.  I'm not sure if
it's checked in or not.  I'll take a look later and close this bug if it has
been checked in.

Comment 5

[[e-mail] (away - not reading bugmail)]

Sean,

I didn't get a chance to check it in. There is a functional patch with one
omission  - it doesn't send updates when "-ms" is used on the commandline.
Please let me know, how I can help with the remaining work.

Comment 6

[Sean Su]

jbetak, thanks for all the work you've done.  I won't have time till probably
next month to start looking at the work you have done due to holidays and things
that have a higher priority.

I will ping you when I have time to look at the bugs you've worked on.

Comment 7

[[e-mail] (away - not reading bugmail)]

Sean,

I found the link, hope the build will be still there (assuming IT hasn't deleted
my account) when you get back. Happy holidays :-)

Comment 8

[[e-mail] (away - not reading bugmail)]

http://rocknroll/users/jbetak/mozilla-win32-progress-bar-test.exe

Comment 9

[Sean Su]

thanks Juraj,

the link still works.  I'll try to save it when I get in to the office.

Comment 10

[Daniel Veditz [:dveditz]]

The GRE installer is long dead