1736258 - composition test failures: test_attachment_intl.js, test_nsMsgCompose2.js, test_componentsExist.js

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Ben Campbell]

A few tests seem to use nsMsgCompose without calling initialize() upon it. They currently die in the nsMsgCompose dtor.

Comment 1

[Ben Campbell]

Attachment: Bug 1736258 - Fix crashes in test_attachment_intl.js, test_nsMsgCompose2.js (regressed due to Bug 1735601). r=darktrojan

Comment 2

[Ben Campbell]

That patch does nothing specific to address test_componentsExist.js, but the test does now run.
The nsMsgCompose dtor no longer crashes when destroying non-initialized objects. The test is just testing object creation, not any actual use, so I think it's OK as is.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1fbbcaf72510
Fix crashes in test_attachment_intl.js, test_nsMsgCompose2.js (regressed due to Bug 1735601). r=darktrojan

Comment 4

[Ben Campbell]

Ideally, all methods on nsMsgCompose should fail if initialize() hasn't been called, but that seems a little overbearing.
I didn't make any changes to test_componentsExist.js - it just creates objects, but doesn't try to do anything with them, so I think it's fine that it doesn't call initialize().

So I'm going to say it's fine now as it is, and close this bug.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9246343 [details]
Bug 1736258 - Fix crashes in test_attachment_intl.js, test_nsMsgCompose2.js (regressed due to Bug 1735601). r=darktrojan

[Triage Comment]
Approved for beta (needed for bug 1735601)

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): "just tests"

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 94.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/fd0c035ba323
Thunderbird 94.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/725accc2f4c3

Comment 7

[Rob Lemley [:rjl]]

Backing out both changes from beta due to build failures caused by uplift of bug 1735601, which this bug is hopelessly ensnared by.

Comment 8

[Rob Lemley [:rjl]]

Backout from 94.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/bc80adac3630
https://hg.mozilla.org/releases/comm-beta/rev/42e4ca274133

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9246343 [details]
Bug 1736258 - Fix crashes in test_attachment_intl.js, test_nsMsgCompose2.js (regressed due to Bug 1735601). r=darktrojan

removing comm-esr91 flag to avoid confusion - please renominate after beta testing is compelte

Comment 10

[Rob Lemley [:rjl]]

Comment on attachment 9246343 [details]
Bug 1736258 - Fix crashes in test_attachment_intl.js, test_nsMsgCompose2.js (regressed due to Bug 1735601). r=darktrojan

No uplift to beta needed as this patch will be included in 95.0beta1 after the merge.

Comment 11

[Ping Chen [:rnons] (away)]

Attachment: 1736258-esr91.patch

[Approval Request Comment]
Rebased to esr91.

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9249329 [details] [diff] [review]
1736258-esr91.patch

[Triage Comment]
Approved for esr91

Comment 13

[Rob Lemley [:rjl]]

Thunderbird 91.3.1:
https://hg.mozilla.org/releases/comm-esr91/rev/cb5046faeb56