1736331 - Reimplement in IOUtils or find an alternative for OS.File.macSetXAttr/OS.File.macGetXAttr

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, task)

Description

[Mark Banner (:standard8)]

OS.File.macSetXAttr and OS.File.macGetXAttr are used in the attribution code.

We should find a way to replace that, as part of the effort to drop OS.File.

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1736331 - Add nsILocalFileMac methods for interacting with extended attributes r?nika

This patch adds support for setting, getting, and reading extended filesystem
attributes on macOS, with helpers for dealing with the "com.apple.quarantine"
attribute, which is the only one we care about.

We cannot get away with not including setXAttr because it is needed in tests
in the attribution code.

Depends on D133835

Comment 2

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1736331 - Add IOUtils methods for dealing with macOS extended filesystem attributes r?gijs

Depends on D133836

Comment 3

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1736331 - Replace OS.File Mac extended attribute APIs with IOUtils r?mixedpuppy

Depends on D133837

Comment 4

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1736331 - Remove OS.File.mac{Get,Set,Remove}XAttr r?gijs

Depends on D133838

Comment 5

[Phabricator Automation]

Comment on attachment 9255412 [details]
Bug 1736331 - Replace OS.File Mac extended attribute APIs with IOUtils r?mixedpuppy

Revision D133838 was moved to bug 1745356. Setting attachment 9255412 [details] to obsolete.

Comment 6

[Phabricator Automation]

Comment on attachment 9255413 [details]
Bug 1736331 - Remove OS.File.mac{Get,Set,Remove}XAttr r?gijs

Revision D133839 was moved to bug 1746676. Setting attachment 9255413 [details] to obsolete.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/275621f46891
Add nsILocalFileMac methods for interacting with extended attributes r=nika
https://hg.mozilla.org/integration/autoland/rev/293085bdd5a1
Add IOUtils methods for dealing with macOS extended filesystem attributes r=Gijs

Comment 8

[Natalia Csoregi [:nataliaCs]]

Backed out for causing bustage on IOUtils.webidl

• backout: https://hg.mozilla.org/integration/autoland/rev/58a45475b5249cce6f9be93ba2824e24819cb3f5

• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=293085bdd5a1794adb4c56fb30b7b70e388d199a

• failure log: https://treeherder.mozilla.org/logviewer?job_id=362134331&repo=autoland&lineNumber=3679

[task 2021-12-22T16:57:01.779Z] 16:57:01    ERROR -  Traceback (most recent call last):
[task 2021-12-22T16:57:01.781Z] 16:57:01     INFO -    File "/builds/worker/checkouts/gecko/dom/bindings/parser/WebIDL.py", line 2551, in complete
[task 2021-12-22T16:57:01.781Z] 16:57:01     INFO -      obj = scope._lookupIdentifier(self.name)
[task 2021-12-22T16:57:01.781Z] 16:57:01     INFO -    File "/builds/worker/checkouts/gecko/dom/bindings/parser/WebIDL.py", line 339, in _lookupIdentifier
[task 2021-12-22T16:57:01.781Z] 16:57:01     INFO -      return self._dict[identifier.name]
[task 2021-12-22T16:57:01.781Z] 16:57:01     INFO -  KeyError: 'bool'
[task 2021-12-22T16:57:01.781Z] 16:57:01     INFO -  During handling of the above exception, another exception occurred:
[task 2021-12-22T16:57:01.781Z] 16:57:01    ERROR -  Traceback (most recent call last):
[task 2021-12-22T16:57:01.781Z] 16:57:01     INFO -    File "/usr/lib/python3.9/runpy.py", line 197, in _run_module_as_main
[task 2021-12-22T16:57:01.781Z] 16:57:01     INFO -      return _run_code(code, main_globals, None,
[task 2021-12-22T16:57:01.781Z] 16:57:01     INFO -    File "/usr/lib/python3.9/runpy.py", line 87, in _run_code
[task 2021-12-22T16:57:01.781Z] 16:57:01     INFO -      exec(code, run_globals)
[task 2021-12-22T16:57:01.781Z] 16:57:01     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/action/webidl.py", line 20, in <module>
[task 2021-12-22T16:57:01.781Z] 16:57:01     INFO -      sys.exit(log_build_task(main, sys.argv[1:]))
[task 2021-12-22T16:57:01.781Z] 16:57:01     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/action/util.py", line 18, in log_build_task
[task 2021-12-22T16:57:01.781Z] 16:57:01     INFO -      return f(*args, **kwargs)
[task 2021-12-22T16:57:01.781Z] 16:57:01     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/action/webidl.py", line 16, in main
[task 2021-12-22T16:57:01.781Z] 16:57:01     INFO -      manager.generate_build_files()
[task 2021-12-22T16:57:01.782Z] 16:57:01     INFO -    File "/builds/worker/checkouts/gecko/dom/bindings/mozwebidlcodegen/__init__.py", line 293, in generate_build_files
[task 2021-12-22T16:57:01.782Z] 16:57:01     INFO -      self._parse_webidl()
[task 2021-12-22T16:57:01.782Z] 16:57:01     INFO -    File "/builds/worker/checkouts/gecko/dom/bindings/mozwebidlcodegen/__init__.py", line 412, in _parse_webidl
[task 2021-12-22T16:57:01.782Z] 16:57:01     INFO -      self._parser_results = parser.finish()
[task 2021-12-22T16:57:01.782Z] 16:57:01     INFO -    File "/builds/worker/checkouts/gecko/dom/bindings/parser/WebIDL.py", line 8651, in finish
[task 2021-12-22T16:57:01.782Z] 16:57:01     INFO -      production.finish(self.globalScope())
[task 2021-12-22T16:57:01.782Z] 16:57:01     INFO -    File "/builds/worker/checkouts/gecko/dom/bindings/parser/WebIDL.py", line 1166, in finish
[task 2021-12-22T16:57:01.782Z] 16:57:01     INFO -      self.finishMembers(scope)
[task 2021-12-22T16:57:01.782Z] 16:57:01     INFO -    File "/builds/worker/checkouts/gecko/dom/bindings/parser/WebIDL.py", line 818, in finishMembers
[task 2021-12-22T16:57:01.782Z] 16:57:01     INFO -      member.finish(scope)
[task 2021-12-22T16:57:01.782Z] 16:57:01     INFO -    File "/builds/worker/checkouts/gecko/dom/bindings/parser/WebIDL.py", line 6025, in finish
[task 2021-12-22T16:57:01.782Z] 16:57:01     INFO -      returnType = returnType.complete(scope)
[task 2021-12-22T16:57:01.782Z] 16:57:01     INFO -    File "/builds/worker/checkouts/gecko/dom/bindings/parser/WebIDL.py", line 3379, in complete
[task 2021-12-22T16:57:01.782Z] 16:57:01     INFO -      self.inner = self.promiseInnerType().complete(scope)
[task 2021-12-22T16:57:01.782Z] 16:57:01     INFO -    File "/builds/worker/checkouts/gecko/dom/bindings/parser/WebIDL.py", line 2553, in complete
[task 2021-12-22T16:57:01.782Z] 16:57:01     INFO -      raise WebIDLError("Unresolved type '%s'." % self.name, [self.location])
[task 2021-12-22T16:57:01.782Z] 16:57:01     INFO -  WebIDL.WebIDLError: error: Unresolved type '<unresolved scope>::bool'., /builds/worker/workspace/obj-build/dom/bindings/IOUtils.webidl line 227:10
[task 2021-12-22T16:57:01.782Z] 16:57:01     INFO -    Promise<bool> hasMacXAttr(DOMString path, UTF8String attr);
[task 2021-12-22T16:57:01.782Z] 16:57:01     INFO -            ^
[task 2021-12-22T16:57:01.782Z] 16:57:01    ERROR -  gmake[4]: *** [Makefile:54: webidl.stub] Error 1

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a34c502e65f
Add nsILocalFileMac methods for interacting with extended attributes r=nika
https://hg.mozilla.org/integration/autoland/rev/5745c2669e88
Add IOUtils methods for dealing with macOS extended filesystem attributes r=Gijs

Comment 10

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages in IOUtils

Backout link: https://hg.mozilla.org/integration/autoland/rev/729ebf78a8e1f8b48afab1883ed6994ec5ebf8fc

Push with failures

Failure log

 INFO -  In file included from Unified_cpp_dom_system0.cpp:2:
[task 2021-12-22T19:53:23.740Z] 19:53:23    ERROR -  /builds/worker/checkouts/gecko/dom/system/IOUtils.cpp:801:44: error: too few arguments to function call, expected 3, have 2
[task 2021-12-22T19:53:23.740Z] 19:53:23     INFO -            return HasMacXAttrSync(file, attr);
[task 2021-12-22T19:53:23.740Z] 19:53:23     INFO -                   ~~~~~~~~~~~~~~~           ^
[task 2021-12-22T19:53:23.740Z] 19:53:23     INFO -  /builds/worker/checkouts/gecko/dom/system/IOUtils.h:419:32: note: 'HasMacXAttrSync' declared here
[task 2021-12-22T19:53:23.741Z] 19:53:23     INFO -    static Result<bool, IOError> HasMacXAttrSync(GlobalObject& aGlobal,
[task 2021-12-22T19:53:23.741Z] 19:53:23     INFO -                                 ^
[task 2021-12-22T19:53:23.741Z] 19:53:23     INFO -  In file included from Unified_cpp_dom_system0.cpp:2:
[task 2021-12-22T19:53:23.743Z] 19:53:23    ERROR -  /builds/worker/checkouts/gecko/dom/system/IOUtils.cpp:1634:10: error: no viable conversion from returned value of type 'bool' to function return type 'Result<nsTArray<uint8_t>, IOUtils::IOError>' (aka 'Result<nsTArray<unsigned char>, mozilla::dom::IOUtils::IOError>')
[task 2021-12-22T19:53:23.743Z] 19:53:23     INFO -    return hasAttr;

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0df890ed09e
Add nsILocalFileMac methods for interacting with extended attributes r=nika
https://hg.mozilla.org/integration/autoland/rev/3d627a038faa
Add IOUtils methods for dealing with macOS extended filesystem attributes r=Gijs

Comment 12

[Atila Butkovits]

Backed out for causing failures at test_ioutils_mac_xattr.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/6d1e19449b7449b33b4afe6d96422c01e9c361ea

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=KRt9fTAaRA2V2IAqxKETCA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=3d627a038faa45c3189c59b84bed021f41972ce3

Failure log: https://treeherder.mozilla.org/logviewer?job_id=362289078&repo=autoland&lineNumber=142610

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c7c570bc463
Add nsILocalFileMac methods for interacting with extended attributes r=nika
https://hg.mozilla.org/integration/autoland/rev/a09866b619ee
Add IOUtils methods for dealing with macOS extended filesystem attributes r=Gijs

Comment 14

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6c7c570bc463
https://hg.mozilla.org/mozilla-central/rev/a09866b619ee