1736386 - Calendar event titles have an ellipsis in Week view

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[cecinestpasunealpaga]

Attachment: example.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

Entered a new event in the (Lightning) calendar.

Actual results:

It show only a small part of the title in the item tile.

Expected results:

I am used to seeing all of the title, of the event item/block is big enough. It worked that way (for .. as long as I can remember), and now it doesn't.

Not sure if this is a 'bug' or a new 'feature'... but it's def. bugging me! :)

Comment 1

[cecinestpasunealpaga]

anyone else experiencing this?

Comment 2

[cecinestpasunealpaga]

Attachment: title_example.png

better screenshot

Comment 3

[Lee Bosch]

I'm seeing this. I'm not sure that this is a new behavior.

Comment 4

[cecinestpasunealpaga]

(In reply to Lee Bosch from comment #3)

I'm seeing this. I'm not sure that this is a new behavior.

I'm 100% sure. I have been using this for years, many times daily. I think this might have been changed since the release of v91 (which I upgraded to recently).

Comment 5

[WaltS48 [:walts48]]

I think there was a recent bug report about this issue, which I can't find right now.

I just checked with version 78.14.0 and see the same in Week, Multiweek and Month views with a title as short as Airgas delivery.

Hovering the mouse pointer and reading the tool tip doesn't work for you?

That's what I have always done, or use Day view, which will also show the ellipsis if the title is too long.

Comment 6

[cecinestpasunealpaga]

Attachment: howitwas.png

this is how it used to be. screenshot taken in TB 78.11.0 64-bit on Windows 10.

Comment 7

[P. Mergey]

I'm 100% sure. I have been using this for years, many times daily. I think this might have been changed since the release of v91 (which I upgraded to recently).

I totally agree: this behavior appeared with the recent version and was not present in version 78.14.0.

Comment 8

[couitchy]

I noticed this too when upgrading from version 78 to 91.
Would it be possible to add some css code in userChrome.css to restore the old behavior?

Comment 9

[Magnus Melin [:mkmelin]]

This is due to the white-space: pre at https://searchfox.org/comm-central/rev/8c9c7ff4460d5a50e047ff8abdde4045024e90a9/calendar/base/themes/common/calendar-views.css#224

Comment 10

[Henry Wilkes (they/them) [:henry-x]]

(In reply to Magnus Melin [:mkmelin] from comment #9)

This is due to the white-space: pre at https://searchfox.org/comm-central/rev/8c9c7ff4460d5a50e047ff8abdde4045024e90a9/calendar/base/themes/common/calendar-views.css#224

Thanks for spotting this. That rule is for the location description, but the corresponding white-space: nowrap rule for the name is here https://searchfox.org/comm-central/rev/8c9c7ff4460d5a50e047ff8abdde4045024e90a9/calendar/base/themes/common/calendar-views.css#207

I can remove it for the non-allday events.

Comment 11

[Henry Wilkes (they/them) [:henry-x]]

The title of this was set to "Calendar event titles have an ellipsis in Week, Multiweek and Month views" (emphasis mine), but the example given for before and after was in only the Week view.

Do you expect the event title to go onto a newline in the Multiweek and Month views boxes as well? I think a single line (with ellipsis) is preferred in those views, but I'm not sure if other people feel the same. Also, I'm not sure if that's a regression from version 78 (I can't check 78 right now). (update: checked in 78 and Multiweek and Month views are single line with ellipses, so this is only a regression in the Week/Day views).

Comment 12

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1736386 - Allow non-allday event names to wrap in the multiday views. r=darktrojan

Comment 13

[couitchy]

(In reply to Henry Wilkes [:henry] from comment #11)

The title of this was set to "Calendar event titles have an ellipsis in Week, Multiweek and Month views" (emphasis mine), but the example given for before and after was in only the Week view.

Do you expect the event title to go onto a newline in the Multiweek and Month views boxes as well? I think a single line (with ellipsis) is preferred in those views, but I'm not sure if other people feel the same. Also, I'm not sure if that's a regression from version 78 (I can't check 78 right now). (update: checked in 78 and Multiweek and Month views are single line with ellipses, so this is only a regression in the Week/Day views).

Great, thanks Henry!
While awaiting the new build, do you think it's possible to reproduce this behavior using userChrome.css?

Comment 14

[Henry Wilkes (they/them) [:henry-x]]

(In reply to couitchy from comment #13)

Great, thanks Henry!
While awaiting the new build, do you think it's possible to reproduce this behavior using userChrome.css?

I don't know much about userChrome.css, but if you want to poke around in it, you can try copying the additional rule I added in the patch. I wouldn't consider it stable to do so though.

Comment 15

[couitchy]

(In reply to Henry Wilkes [:henry] from comment #14)

I don't know much about userChrome.css, but if you want to poke around in it, you can try copying the additional rule I added in the patch. I wouldn't consider it stable to do so though.
Yes I already tried but unfortunately it is not working.
Thanks anyway!

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8654b9025640
Allow non-allday event names to wrap in the multiday views. r=darktrojan

Comment 17

[Henry Wilkes (they/them) [:henry-x]]

Comment on attachment 9251893 [details]
Bug 1736386 - Allow non-allday event names to wrap in the multiday views. r=darktrojan

[Approval Request Comment]
Regression caused by (bug #): bug 1694820
User impact if declined: Longer event names will be clipped to the first line in the calendar week (and day) view.
Testing completed (on c-c, etc.): No
Risk to taking this patch (and alternatives if risky): Low risk. Small CSS fix.

Comment 18

[Wayne Mery (:wsmwk)]

Comment on attachment 9251893 [details]
Bug 1736386 - Allow non-allday event names to wrap in the multiday views. r=darktrojan

[Triage Comment]
Approved for beta

Comment 19

[Rob Lemley [:rjl]]

Thunderbird 95.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/22f05101806a

Comment 20

[Henry Wilkes (they/them) [:henry-x]]

I just realised this patch also make the all-day header items in the week view wrap, which is different from 78. But I actually think this works better for the week view.

But anyone following can let me know if it is bad for some reason. I suppose it could be annoying if you have events with long names.

Comment 21

[WaltS48 [:walts48]]

I have 3 events for today with long names, but there is a scroll bar I can use to view them in the Week view.

Saturday in Week view is a bit cutoff in today's Daily in Week view with the Calendar and Today panes enabled.

Comment 22

[WaltS48 [:walts48]]

Attachment: image.png

Comment 23

[WaltS48 [:walts48]]

So sorry, just noticed the horizontal scrollbar at the bottom of the Week view.

Comment 24

[WaltS48 [:walts48]]

Attachment: Missing scrollbars.png

The scrollbars are missing in my testing 95.0b5 on Windows 10 and Fedora Linux, and the user needs to scroll each item to see the whole Title.

More of the Title is shown in Daily and the scrollbars appear.

Comment 25

[Henry Wilkes (they/them) [:henry-x]]

(In reply to WaltS48 [:walts48] from comment #24)

Created attachment 9253108 [details]
Missing scrollbars.png

The scrollbars are missing in my testing 95.0b5 on Windows 10 and Fedora Linux, and the user needs to scroll each item to see the whole Title.

More of the Title is shown in Daily and the scrollbars appear.

Where do you expect to see scrollbars? I can't tell if anything is overflowing in the screenshot.

NOTE: the whole all-day header area currently scrolls as one. The scrolling is being improved in bug 1713130, but that won't be coming to 91.

Comment 26

[WaltS48 [:walts48]]

Attachment: Windows-Daily.png

Hope these help.
Today's Daily 96.0a1 on Windows 10.

Comment 27

[WaltS48 [:walts48]]

Attachment: Windows-Beta.png

Windows 95.0b5.
Missing text and scrollbars in Week View.

I did discover I could select each item in the view for today and scroll it using the mouse wheel to read the text, so I guess it isn't really missing, just not displaying like in Daily.

See the same on Linux.

Using the tooltip displays all the information for the events, and is much quicker than scrolling.

Comment 28

[WaltS48 [:walts48]]

A tad better when I reset layout.css.devPixelsPerPx to the default -1.0 on Windows 10.
It was 1.25, but Linux is the default.

Comment 29

[Henry Wilkes (they/them) [:henry-x]]

(In reply to WaltS48 [:walts48] from comment #27)

Created attachment 9253290 [details]
Windows-Beta.png

Windows 95.0b5.
Missing text and scrollbars in Week View.

I did discover I could select each item in the view for today and scroll it using the mouse wheel to read the text, so I guess it isn't really missing, just not displaying like in Daily.

See the same on Linux.

Using the tooltip displays all the information for the events, and is much quicker than scrolling.

Thanks. I think the daily release is benefiting from some of bug 1713130, but this is going to change soon anyway.

For the 91 patch, I'll keep the 78 behaviour and just not allow all-day items to take up multiple lines (comment 20).

Comment 30

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug1736386-esr91.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1694820
User impact if declined: Non-allday events with long names will have their name clipped to the first line in the calendar week (and day) view.
Testing completed (on c-c, etc.): No
Risk to taking this patch (and alternatives if risky): Low risk. Small CSS fix.

Comment 31

[Wayne Mery (:wsmwk)]

Comment on attachment 9253383 [details] [diff] [review]
Bug1736386-esr91.patch

[Triage Comment]
Approved for esr91

Comment 32

[Rob Lemley [:rjl]]

Thunderbird 91.4.1:
https://hg.mozilla.org/releases/comm-esr91/rev/fe52fb96eb0f

Comment 33

[cecinestpasunealpaga]

(In reply to Rob Lemley [:rjl] from comment #32)

Thunderbird 91.4.1:
https://hg.mozilla.org/releases/comm-esr91/rev/fe52fb96eb0f

Hi Rob, not sure if I should comment here, but could you explain to us complete noobs how to make this work? Have been desperately waiting for a solution. Thank you!

Best,
Rutger

Comment 34

[WaltS48 [:walts48]]

Rutger,

You wait for the 91.4.1 release candidate to be tested and approved, then wait for the release and an update from 91.4.0.

If it is anything like in the week view of my 96.0b2, there will still be an ellipsis if there is a Location set.

Comment 35

[WaltS48 [:walts48]]

Attachment: weekview.png

Still seeing ellipsis in Week View, testing the 91.4.1 release candidate in regular and safe mode on Windows 10.

I made sure Windows was set to 100% for the display and TB at -1.0 for layout.css.devPixelsPerPx.

Comment 36

[Henry Wilkes (they/them) [:henry-x]]

(In reply to WaltS48 [:walts48] from comment #35)

Still seeing ellipsis in Week View, testing the 91.4.1 release candidate in regular and safe mode on Windows 10.

That screenshot only shows events in the all-day header. This was intended for the 91 patch (comment 29). The scheduled/timed events below the all-day header should be multi-line when necessary (provided they have enough vertical space).