1736397 - Replace sweeping with tracing weak edges in WeakCache implementation

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P3)

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1736397 - Part 1: Change the WeakCache interface to traceWeak(), but still call sweep() internally r?sfink

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1736397 - Part 2: Give hash table traceWeak methods a boolean return value r?sfink

Depends on D128856

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1736397 - Part 3: Replace sweeping with tracing weak edges for WeakCached HashMaps r?sfink

Depends on D128857

Comment 4

[Jon Coppeard (:jonco)]

Attachment: Bug 1736397 - Part 4: Replace sweeping with tracing weak edges for WeakCached HashSets r?sfink

Depends on D128858

Comment 5

[Jon Coppeard (:jonco)]

Attachment: Bug 1736397 - Part 5: Replace sweeping with tracing weak edges for unspecialized WeakCached things r?sfink

Making this change meant fixing WeakCached things that supplied their own sweep
method at the same time because the custom sweep method would no longer be
called. This dragged in a bunch of other changes but it's all along the same
lines as the previous patches.

Depends on D128859

Comment 6

[Jon Coppeard (:jonco)]

Attachment: Bug 1736397 - Part 6: Use tracing for the incremental read barrier on WeakCached maps and sets r?sfink

It's slightly annoying that we now have to store a tracer rather than just a
bool, but it's necessary because these container methods don't have any context
we can get it from.

Depends on D128860

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d528f1cf137
Part 1: Change the WeakCache interface to traceWeak(), but still call sweep() internally r=sfink
https://hg.mozilla.org/integration/autoland/rev/446442e02d07
Part 2: Give hash table traceWeak methods a boolean return value r=sfink
https://hg.mozilla.org/integration/autoland/rev/a995c4e762d7
Part 3: Replace sweeping with tracing weak edges for WeakCached HashMaps r=sfink
https://hg.mozilla.org/integration/autoland/rev/e753336f6a84
Part 4: Replace sweeping with tracing weak edges for WeakCached HashSets r=sfink
https://hg.mozilla.org/integration/autoland/rev/aca331d41a22
Part 5: Replace sweeping with tracing weak edges for unspecialized WeakCached things r=sfink
https://hg.mozilla.org/integration/autoland/rev/30cf1a138099
Part 6: Use tracing for the incremental read barrier on WeakCached maps and sets r=sfink

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/9d528f1cf137
https://hg.mozilla.org/mozilla-central/rev/446442e02d07
https://hg.mozilla.org/mozilla-central/rev/a995c4e762d7
https://hg.mozilla.org/mozilla-central/rev/e753336f6a84
https://hg.mozilla.org/mozilla-central/rev/aca331d41a22
https://hg.mozilla.org/mozilla-central/rev/30cf1a138099