1736518 - [Linux] Polish titlebar config

Status: RESOLVED FIXED

(Core :: Widget: Gtk, task)

Description

[Martin Stránský [:stransky] (ni? me)]

Right now we don't test titlebar rendering in mozilla testsuite. That leads to various issues and regressions.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1736518 [Linux] Remove hardcoded browser.tabs.drawInTitlebar preference r?emilio

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1736518 [Linux] Remove -moz-gtk-csd-hide-titlebar-by-default and set browser.tabs.drawInTitlebar directly r?emilio

Recently -moz-gtk-csd-hide-titlebar-by-default is used to control initial state of titlebar rendering on Linux.
This is used on Linux only, such preference confuses Mozilla test suite which expects browser.tabs.drawInTitlebar only
as it's used on other platforms.

Let's align Linux behaviors with Win/Mac and set browser.tabs.drawInTitlebar directly at browser start (if it's not already set).

Depends on D128995

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1736518 - Make browser.tabs.drawInTitlebar a tri-state. r=stransky!,Gijs!

To more properly support Linux having a different default at runtime.

Expose the resolved value in appinfo for convenience, and use it in the
front-end as needed.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1736518 - Fix CSD check in nsLookAndFeel. r=stransky

This is a regression from bug 1681356. nsWindow::GtkWindowDecoration()
default-initializes a GtkWindowDecoration, which ends up being
GTK_DECORATION_SYSTEM since that's the first variant.

Fix the check by using the proper function
GetSystemGtkWindowDecoration(). Quite a footgun...

Depends on D129004

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1736518 - Remove GTK_CSD_DECORATION_UNKNOWN. r=stransky

Clean up the check while at it.

Depends on D129005

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62d204b08dce
Make browser.tabs.drawInTitlebar a tri-state. r=stransky,Gijs
https://hg.mozilla.org/integration/autoland/rev/ad3d2766d9da
Fix CSD check in nsLookAndFeel. r=stransky
https://hg.mozilla.org/integration/autoland/rev/537090f8fa57
Remove GTK_CSD_DECORATION_UNKNOWN. r=stransky

Comment 7

[Sandor Molnar]

https://hg.mozilla.org/mozilla-central/rev/62d204b08dce
https://hg.mozilla.org/mozilla-central/rev/ad3d2766d9da
https://hg.mozilla.org/mozilla-central/rev/537090f8fa57

Comment 8

[Mathew Hodson]

Should this bug still be open? Maybe it would better to create a new followup bug if there is going to be more later.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Yeah maybe we should retitle this bug and close it? WDYT Martin?

Comment 10

[Martin Stránský [:stransky] (ni? me)]

There's try with enabled CSD in try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=018a3bcf76022f97eb1481d95c4d83aebed002e8
so let's see how it works.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Hm, the try does not look good. Okay, let's close it and file another one for CSD enabled in testsuite.