1736523 - [Linux] Drag and drop stopped working

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P1)

Description

[Kestrel]

Drag and drop no longer works on Ubuntu 21.04. Tabs cannot be dragged around the tab strip, dropping on the tab strip opens a new window on Wayland. Dropping text into the address bar or between tabs doesn't do anything etc. Occurs on both Wayland and XWayland.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1117eee12de7907d215343eafb1156d50e4b7ab5&tochange=f4a1cfc1bb0f7d72baa621c2a145358b74de8945

Regressed by Bug 1736377.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Interesting, seems to be related to the inner window changes. Will look at it.

Comment 3

[Marco Castelluccio [:marco]]

[Tracking Requested - why for this release]: Drag & drop is an important feature.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1736523 [Linux] Get inner window for D&D operations r?emilio

Comment 5

[B.J. Herbison]

Possibly related to the inability to customize the toolbar in today's Nightly. Bug 1736683.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2777033b7d3
[Linux] Get inner window for D&D operations r=jhorak

Comment 9

[Kevin Locke]

In regards to the title change, is this issue confined to the tab bar? I'm seeing several other drag and drop issues (to rearrange bookmarks on the Bookmarks Toolbar, or in Manage Bookmarks, toolbar elements in Customize Toolbar, emails in Thunderbird). I haven't confirmed they all have the same regression range, but suspect they do. Let me know if you want confirmation or if I should open separate bugs.

Comment 10

[B.J. Herbison]

There is already bug 1736683 for Customize Toolbar, but it was duped to this bug.

Comment 11

[Daniel Holbert [:dholbert]]

Sorry, the title change was my own misunderstanding (and failed attempt at clarification). I made that tweak after encountering this with the tab-bar, and I hadn't realized that other forms of drag-and-drop were also broken. I'll restore the original title, since I assume this bug & the fix covers the broader issue. (And to the extent that any other drag&drop behavior is still broken after this fix hits Nightlies, we can of course track followup work in new/un-duped bugs.)

Comment 12

[Kevin Locke]

No worries. Thanks :dholbert! Just to put my own doubts to rest, I can confirm that creating or rearranging bookmarks by drag and drop to the Bookmarks Toolbar bisects to the same range, so is likely the same issue. Will keep an eye on it.

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/d2777033b7d3

Comment 14

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 95.0a1 (2021-10-19) on Ubuntu 21.0.4.
The drag and drop work as expected on Ubuntu 21.04 with Firefox 95.0b3.