Closed Bug 1736558 Opened 2 months ago Closed 2 months ago

Some ProcessRestyledFrames cleanups.

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(4 files)

No description provided.

Shouldn't have any behavior change either and is more similar to the
containing block reframe.

Depends on D128874

Type: defect → enhancement
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/753d2e8989de
Factor out containing block change processing to its own function. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/ea8736bd655c
Move AddOrRemoveTransform handling to the branch where all other change hints that don't cause reframes are processed. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/29c466b6238f
Early-out from the loop after handling reframes. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/1943f99e1345
Deal with scrollbar changes inside the loop. r=dholbert

Minor followup - per my afterthought in the last patch (RE the discussion about null-checks there), I think we can also promote the explicit null-check to an assertion in TryToHandleContainingBlockChange as well (the function added in the first patch here), right?

Here in particular:
https://hg.mozilla.org/integration/autoland/annotate/1943f99e1345bd243f3ee6c68d37bfcae4b95ac1/layout/base/RestyleManager.cpp#l1356

If I'm understanding that correctly, would you mind landing that as a followup? That'll make us more consistent about how we depend on & validate that invariant in that section of code.

Flags: needinfo?(emilio)
You need to log in before you can comment on or make changes to this bug.