1736558 - Some ProcessRestyledFrames cleanups.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1736558 - Factor out containing block change processing to its own function. r=#layout-reviewers

No behavior change.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1736558 - Move AddOrRemoveTransform handling to the branch where all other change hints that don't cause reframes are processed. r=#layout-reviewers

Depends on D128872

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1736558 - Early-out from the loop after handling reframes. r=#layout-reviewers

Depends on D128873

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1736558 - Deal with scrollbar changes inside the loop. r=#layout-reviewers

Shouldn't have any behavior change either and is more similar to the
containing block reframe.

Depends on D128874

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/753d2e8989de
Factor out containing block change processing to its own function. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/ea8736bd655c
Move AddOrRemoveTransform handling to the branch where all other change hints that don't cause reframes are processed. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/29c466b6238f
Early-out from the loop after handling reframes. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/1943f99e1345
Deal with scrollbar changes inside the loop. r=dholbert

Comment 6

[Daniel Holbert [:dholbert]]

Minor followup - per my afterthought in the last patch (RE the discussion about null-checks there), I think we can also promote the explicit null-check to an assertion in TryToHandleContainingBlockChange as well (the function added in the first patch here), right?

Here in particular:
https://hg.mozilla.org/integration/autoland/annotate/1943f99e1345bd243f3ee6c68d37bfcae4b95ac1/layout/base/RestyleManager.cpp#l1356

If I'm understanding that correctly, would you mind landing that as a followup? That'll make us more consistent about how we depend on & validate that invariant in that section of code.

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/753d2e8989de
https://hg.mozilla.org/mozilla-central/rev/ea8736bd655c
https://hg.mozilla.org/mozilla-central/rev/29c466b6238f
https://hg.mozilla.org/mozilla-central/rev/1943f99e1345

Comment 8

[Emilio Cobos Álvarez (:emilio)]

https://hg.mozilla.org/integration/autoland/rev/38eead280671c044a18475dd7bc8f6566b554098

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/38eead280671