Closed Bug 1736558 Opened 2 months ago Closed 2 months ago

Some ProcessRestyledFrames cleanups.


(Core :: CSS Parsing and Computation, enhancement)




95 Branch
Tracking Status
firefox95 --- fixed


(Reporter: emilio, Assigned: emilio)




(4 files)

No description provided.

Shouldn't have any behavior change either and is more similar to the
containing block reframe.

Depends on D128874

Type: defect → enhancement
Pushed by
Factor out containing block change processing to its own function. r=dholbert
Move AddOrRemoveTransform handling to the branch where all other change hints that don't cause reframes are processed. r=dholbert
Early-out from the loop after handling reframes. r=dholbert
Deal with scrollbar changes inside the loop. r=dholbert

Minor followup - per my afterthought in the last patch (RE the discussion about null-checks there), I think we can also promote the explicit null-check to an assertion in TryToHandleContainingBlockChange as well (the function added in the first patch here), right?

Here in particular:

If I'm understanding that correctly, would you mind landing that as a followup? That'll make us more consistent about how we depend on & validate that invariant in that section of code.

Flags: needinfo?(emilio)
You need to log in before you can comment on or make changes to this bug.