1736566 - The theme resets after the upgrade spotlight is dismissed if the theme was previously enabled from another window while the upgrade spotlight is displayed

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P3)

Description

[Marius Coman [:mcoman], Ecosystem QA - PTO until 8th of November, for any requests ping :cmuresan]

Attachment: rec of the issue.gif

[Affected versions]:

• Firefox Release 93.0 - Build ID: 20210927210923
• Firefox Beta 94.0b7 - Build ID: 20211017185800
• Firefox Nightly 95.0a1 - Build ID: 20211018214442

[Affected Platforms]:

• Windows 10 x64
• Windows 7 x64
• macOS 11.6
• Ubuntu 20.04 x64

[Prerequisites]:

• Have an older version of the Firefox browser installed (e.g. Firefox 92).

[Steps to reproduce]:

1. Open the browser using the profile from prerequisites.
2. Open a new window and update the browser to the latest version.
3. Focus the window without the upgrade spotlight and navigate to the "about:addons" page.
4. Select the "Themes" section and enable any theme.
5. Focus the window containing the upgrade spotlight and press the "Esc" key.
6. Observe the behavior.

[Expected result]:

• The upgrade spotlight is dismissed and the previously enabled theme is still active.

[Actual result]:

• The upgrade spotlight is dismissed and the theme is reset to the default one.

[Additional Notes]:

• Attached a screen recording of the issue.

Comment 1

[Ed Lee :Mardak]

This kinda goes away with bug 1740623 as it removes the start screen, so if the user does change the theme while the upgrade spotlight is shown, it reverts to the original active theme when the upgrade spotlight was shown. So…

1. see colorway screen which picks a random color
2. change theme from another window

Although I suppose it's unclear if it should be:

• close colorway triggering "keep previous theme" behavior
• close colorway keeping theme from step 2

Comment 2

[Ed Lee :Mardak]

Bug 1740623 removes the ability to change the theme before seeing the colorway screen, so the correct "previous" theme should be reverted-to when selecting that secondary button now.

https://hg.mozilla.org/mozilla-central/rev/ce741f5787a4

Comment 3

[Robert Martin [:romartin], Ecosystem QA]

I've verified this issue with the steps provided in the description using Firefox Beta 96.0b2 (Build ID: 20211207185904) updated from Firefox Beta 95.0b8 (Build ID: 20211116185800) on Windows 10 x64, macOS 11.6, and Ubuntu Linux 20.04 x64, and I've observed the following:

1. Focus the Window that does NOT have the Upgrade Spotlight displayed.
2. Navigate to the "Themes" section from the "about:addons" page.
3. Enable any available Theme.
4. Focus the Firefox Window that has the spotlight still displayed and dismiss the spotlight by pressing the "Esc" keyboard key, or by clicking the "Keep previous theme" secondary button

[Actual result]:

• The applied browser theme is the one that was set before the upgrade happened and not the one that was selected from a different Window.

@Ed, is the behavior from the above actual result the expected behavior, or should we reopen the bug?

Comment 4

[Ed Lee :Mardak]

Yeah that's expected. The main change is that now users see the "keep previous theme" button when hitting escape or clicking that button, so in a sense the user is confirming to go back to the previous theme (before the about:addons theme change). Previously, the user could see the start/welcome screen without any indication the theme would be reverted.

Comment 5

[Robert Martin [:romartin], Ecosystem QA]

Marking this issue as VERIFIED based on the verification done and mentioned in comment 3 and the answer received in comment 4.