1736577 - [wpt-sync] Sync PR 31313 - Need to propagate tallest unbreakable before forced breaks.

Status: RESOLVED FIXED

(Core :: Layout: Columns, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 31313 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31313
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Need to propagate tallest unbreakable before forced breaks.

Even if there's a forced break inside the child added to the fragment
builder, we need to propagate the tallest unbreakable block-size, to get
column balancing right.

This fixes an existing test, but I felt that we needed a test that more
clearly illustrates this fix, so added that. The existing test still
fails in legacy layout, but for a different reason (layout is correct,
but outline painting order is wrong).

Took the opportunity to rename PropagateBreak() to PropagateBreakInfo(),
since this method doesn't only care about actual breaks. Also, no need
to call this one if no block fragmentation is involved.

Bug: 829028
Change-Id: Ie951817095267567b9fae578fd519b4ba76dc24c
Reviewed-on: https://chromium-review.googlesource.com/3231178
WPT-Export-Revision: 26ca2bdbd75b19096a0360bad7da69c305c6930b

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=819c95f6fab1ec90426999cec79204737c3fb546

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56bf0ce77803
[wpt PR 31313] - Need to propagate tallest unbreakable before forced breaks., a=testonly

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/56bf0ce77803