1736587 - Add applyTargeting param to about:studies preview URLS

Status: RESOLVED FIXED

(Firefox :: Nimbus Desktop Client, enhancement, P1)

Description

[Kate Hudson :k88hudson]

If a nimbus preview URL includes applyTargeting, when force-enrolling, we should also check targeting.

This should NOT include bucketing.

Comment 1

[Beth Rennie [:beth] (she/her)]

about:studies URLs allow us to QA recipes in preview mode. However, this force enrolls you in the experiment without checking any targeting. We would like to be able to use aabout:studies to validate targeting by appending ?applyTargeting to a preview URL.

The code for opting in to experiments begins in AboutPages.jsm, goes through RemoteSettingsExperimentLoader.optInToExperiment, and ends up in ExperimentManager.forceEnroll.

We'll want to add an extra param to optInToExperiment specifying if we should validate the targeting. An example of where we check targeting is in RemoteSettingsExperimentLoader.updateRecipes. If targeting fails, we'll want to include a useful message (via an exception) that targeting was the reason we could not enroll.

Comment 3

[Pushpanjali]

I am an outreachy applicant. Can I contribute to this bug?

Comment 4

[Beth Rennie [:beth] (she/her)]

Pushpanjali, yes. The instructions above are a bit out of date due to refactoring, so here are some updated ones:

1. Update about-studies.js to also capture the applyTargeting query parameter.
2. Update RemoteSettingsExperimentLoader to grab the applyTargeting parameter, defaulting to false.
3. Update the EnrollmentsCtx constructor call to set shouldCheckTargeting: applyTargeting

Comment 5

[Pushpanjali]

Yes, sir.
I am working on it.

Comment 6

[Pushpanjali]

Attachment: Bug 1736587 - Add applyTargeting param to about:studies preview URLS r=barret

Comment 7

[Pushpanjali]

Sir, Can you help me in writing the unit test.

Comment 8

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1736587 - Optionally apply targeting when opting in to experiments r?emcminn

Depends on D173330

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53e8e97bbe4e
Optionally apply targeting when opting in to experiments r=emcminn

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/53e8e97bbe4e