Closed Bug 1736627 Opened 3 years ago Closed 3 years ago

Remove or update probes expiring in Firefox 96: HTTP*

Categories

(Core :: Networking: HTTP, task, P1)

task

Tracking

()

RESOLVED FIXED
Tracking Status
thunderbird_esr91 --- unaffected
firefox-esr91 --- unaffected
firefox93 --- unaffected
firefox94 --- unaffected
firefox95 --- unaffected
firefox96 + disabled

People

(Reporter: telemetry-probes, Assigned: nhnt11)

References

Details

(Whiteboard: [probe-expiry-alert][necko-triaged])

Attachments

(2 files)

The following Firefox probes will expire in the next major Firefox nightly release: version 96 [1].

HTTP3_UPLOAD_TIME_10M_100M
HTTP3_UPLOAD_TIME_GT_100M
HTTP_PRELOAD_IMAGE_STARTREQUEST_DELAY
DOCUMENT_PRELOAD_IMAGE_ASYNCOPEN_DELAY

What to do about this:

  1. If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
  2. If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].

If you have any problems, please ask for help on the #data-help Slack channel or the #telemetry Matrix room at https://chat.mozilla.org/#/room/#telemetry:mozilla.org. We'll give you a hand.

Your Friendly, Neighborhood Telemetry Team

[1] https://wiki.mozilla.org/Release_Management/Calendar
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://github.com/mozilla/data-review/blob/master/renewal_request.md

This is an automated message sent from probe-scraper. See https://github.com/mozilla/probe-scraper for details.

The following probes should stay in place but we should let them expire. We plan to use hem again in the future.
HTTP3_UPLOAD_TIME_10M_100M
HTTP3_UPLOAD_TIME_GT_100M

These probes should be updates:
HTTP_PRELOAD_IMAGE_STARTREQUEST_DELAY
DOCUMENT_PRELOAD_IMAGE_ASYNCOPEN_DELAY

Severity: -- → N/A
Priority: -- → P2
Whiteboard: [probe-expiry-alert] → [probe-expiry-alert][necko-triaged]

[Tracking Requested - why for this release]:

The expired probes cause a permanent test failure of netwerk/test/unit/test_http3_large_post_telemetry.js on Linux and macOS debug. I will disable the test temporarily to get central green again. This had been missed because there was another test failure for the task in the version increase simulations and this failed only on two platforms.

Flags: needinfo?(nhnt11)
Flags: needinfo?(dd.mozilla)
Priority: P2 → P1
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/mozilla-central/rev/51a532bcb9d0 disable test_http3_large_post_telemetry.js temporarily until telemetry probe got extended. a=Aryx
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Flags: needinfo?(nhnt11)
Flags: needinfo?(dd.mozilla)

Dragana, how can we best ensure that if we re-enable the H3 upload time probes, we will also re-enable the tests?

Also, for the probes to be renewed, we need to answer "Why was the initial period of collection insufficient?" in the data review. What's the reason?

Flags: needinfo?(dd.mozilla)

The project that was using this probes got postponed therefore we need to extend the probes.

Flags: needinfo?(dd.mozilla)
Attachment #9255157 - Flags: data-review?(chutten)

Comment on attachment 9255157 [details]
Data review request for renewal

PRELIMINARY NOTES:
(Technically the approval's on #c3 not #c2)

DATA REVIEW RESPONSE:

Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes.

Is the data collection covered by the existing Firefox Privacy Notice?

Yes.


Result: datareview+

Attachment #9255157 - Flags: data-review?(chutten) → data-review+
Pushed by nhnt11@gmail.com: https://hg.mozilla.org/integration/autoland/rev/13408d393eb3 Renew image preload delay telemetry probes until fx 103. r=necko-reviewers,valentin
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: leave-open
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: