1736657 - Incorrect HCM styling for URL bar result buttons

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Morgan Reschenberg [:morgan]]

Attachment: image.png

STR:

1. Enable windows high contrast mode
2. Launch firefox with a clean profile
3. Click the URL bar

Expected:
A tip is shown, and the button to dismiss it is styled in windows HCM "button text/background" colors

Actual:
A tip is shown, and the button to dismiss it is styled in white and blue.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Dão Gottwald [:dao]]

I believe this should be fixed, Morgan, can you confirm?

Comment 3

[Dão Gottwald [:dao]]

Sam says he's able to reproduce some weirdness here.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Attachment: bug-1736657-search-simpler.png

this is what I get on windows HCM. So the button colors have changed but I think its ironically lower contrast now. There's no border and the difference between the popup background and button background is quite subtle

Comment 5

[Morgan Reschenberg [:morgan]]

(In reply to Sam Foster [:sfoster] (he/him) from comment #4)

Created attachment 9363745 [details]
bug-1736657-search-simpler.png

this is what I get on windows HCM. So the button colors have changed but I think its ironically lower contrast now. There's no border and the difference between the popup background and button background is quite subtle

These are closer to the right colours, but not the right styling -- see our HCM component library (primary button) for what we're expecting here

Comment 6

[Dão Gottwald [:dao]]

Attachment: Bug 1736657 - Add outline to urlbar buttons in high contrast mode. r=adw

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25dccdc264e1
Add outline to urlbar buttons in high contrast mode. r=adw

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/25dccdc264e1