1736690 - Remove or update probes expiring in Firefox 96: pictureinpicture.most_concurrent_players

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task)

Description

[telemetry-probes]

The following Firefox probes will expire in the next major Firefox nightly release: version 96 [1].

pictureinpicture.most_concurrent_players

What to do about this:

1. If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
2. If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].

If you have any problems, please ask for help on the #data-help Slack channel or the #telemetry Matrix room at https://chat.mozilla.org/#/room/#telemetry:mozilla.org. We'll give you a hand.

Your Friendly, Neighborhood Telemetry Team

[1] https://wiki.mozilla.org/Release_Management/Calendar
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://github.com/mozilla/data-review/blob/master/renewal_request.md

This is an automated message sent from probe-scraper. See https://github.com/mozilla/probe-scraper for details.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

[Tracking Requested - why for this release]: toolkit/components/pictureinpicture/tests/browser_multiPip.js would fail if the probe expired.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Reminder: This has to be landed by Sunday EOD and Thursday is the last working day.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Per bug 1730039 comment 3, I'm going to update these probes and make them stop expiring.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1736690 - Make the Picture-in-Picture most_concurrent_players scalar probe never expire. data-review=willkg, r?mtigley!

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Data collection renewal request.md

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Comment on attachment 9248060 [details]
Bug 1736690 - Make the Picture-in-Picture most_concurrent_players scalar probe never expire. data-review=willkg, r?mtigley!

Will, could you as an East Coast person review this? That would more room for maneuver to fix the failure from the version increase today and getting the version increase also merged to autoland (there is a big WebRTC expected to land on mozilla-central today and it shall be merged to autoland rather soon to prevent conflicts). Thank you.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

I apologize for not getting this over the line in time. :/

If it makes things easier, we can disable the test for now to allow the uplift / merge to complete, and then I can take point on getting this patch landed and the test re-enabled afterwards.

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

Comment on attachment 9248060 [details]
Bug 1736690 - Make the Picture-in-Picture most_concurrent_players scalar probe never expire. data-review=willkg, r?mtigley!

I didn't see this until just now--sorry about that.

The request looks ok to me except that since it's extending the expiration to forever, the data request needs to specify who is responsible for the probe going forward and it doesn't have that. That's not reflected in the form, so I wrote up an issue in the data-review repo to figure that out.

Also, with "forever" probes, it's recommended there are tests to make sure the probe is still working. I didn't see tests in this changeset. I didn't go back to look at the original changesets and what's happened since then. Is there a test to make sure the probe is working?

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Attachment: Data collection renewal request.md

Comment 11

[Will Kahn-Greene [:willkg] ET needinfo? me]

Comment on attachment 9248688 [details]
Data collection renewal request.md

Looks good. Thank you!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b170ccc84750
Make the Picture-in-Picture most_concurrent_players scalar probe never expire. data-review=willkg, r=mtigley

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/c8fdcf75317d
Make the Picture-in-Picture most_concurrent_players scalar probe never expire. data-review=willkg, r=mtigley a=Aryx

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c8fdcf75317d

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b170ccc84750

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Doesn't need to be uplifted to Beta since the probe isn't expiring in 95 anyway.