Closed Bug 1736730 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31322 - [FlexNG] Intrinsic block size when fragmenting

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31322 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31322
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[FlexNG] Intrinsic block size when fragmenting

The intrinsic block size should only include content in the current
fragmentainer. However, GiveLinesAndItemsFinalPositionAndSize()
requires us to know the total block size of the flex container
(ignoring any fragmentation).

To handle both cases, the CL updates the logic to keep track of
the total intrinsic block size, as well as an accumulated intrinsic
block size. In the case where we are not fragmenting, these values
will be the same.

Tests have been added for single-line column flex. Tests for the
other container types will follow once fragmentation support is
added.

One remaining open question is how to handle the case where a column
flex container has a line that extends past the last item. Should
this be included in the intrinsic block size when fragmenting?

Bug: 660611
Change-Id: Ie43e42ae625e0fd771d63bcecc62ef09faa86eb9
Reviewed-on: https://chromium-review.googlesource.com/3229839
WPT-Export-Revision: 617fa0aaaa11b1f721786cde456ffd89a5d1558a

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

PASS: 1
FAIL: 1

Safari

PASS: 1
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-break/flexbox/flex-container-fragmentation-007.tentative.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/24181a59ff63
[wpt PR 31322] - [FlexNG] Intrinsic block size when fragmenting, a=testonly
https://hg.mozilla.org/integration/autoland/rev/362a1cb71cf2
[wpt PR 31322] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/24181a59ff63
https://hg.mozilla.org/mozilla-central/rev/362a1cb71cf2

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.