1736737 - Refactor integration with template helpers and ArrayBufferOrView type hierarchy

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement)

Description

[Steve Fink [:sfink] [:s:]]

Right now, things like WrappedPtrOperations are using macros and an explicit list of types, but this could be done with templates. (When experimenting with making these types work with Heap<T>, I encountered this.)

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1736737 - Use template magic to specialize WrappedPtrOperations for ArrayBufferOrView subtypes

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1736737 - Slightly restructure IsHeapConstructibleType and add template param to allow conditionally enabling specializations

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1736737 - Implement Heap<ArrayBufferOrView> (for all subtypes)

Comment 4

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1736737 - Change Heap<T> constructors to accept non-default-constructible T

Comment 5

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1736737 - Move SafelyInitialized into a struct to allow partial specialization.

Comment 6

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1736737 - Augment the WrappedPtrOperations for ArrayBufferOrView subclasses.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43a22e362156
Use template magic to specialize WrappedPtrOperations for ArrayBufferOrView subtypes r=jonco
https://hg.mozilla.org/integration/autoland/rev/61da0b175b0b
Change Heap<T> constructors to accept non-default-constructible T r=jonco
https://hg.mozilla.org/integration/autoland/rev/0c286f5836f6
Move SafelyInitialized into a struct to allow partial specialization. r=jonco
https://hg.mozilla.org/integration/autoland/rev/aa3037448983
Augment the WrappedPtrOperations for ArrayBufferOrView subclasses. r=jonco
https://hg.mozilla.org/integration/autoland/rev/4ac615dbeb56
Implement Heap<ArrayBufferOrView> (for all subtypes) r=jonco

Comment 8

[Iulian Moraru]

Backed out for causing spidermonkey and bp-hybrid build bustages.

Push with failures

Failure log for Linux x64 debug Spidermonkey builds hazard
Failure log for Linux x64 debug Spidermonkey builds spidermonkey-sm-compacting
Failure log for Linux x64 debug Spidermonkey builds spidermonkey-sm-nonunified
Failure log for Linux x64 debug Spidermonkey builds spidermonkey-sm-rootanalysis
Failure log for Linux x64 plain build-linux64-hybrid
Failure log for Windows 2012 x64 debug build-win64-hybrid

Backout link

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1937d943bc78
Use template magic to specialize WrappedPtrOperations for ArrayBufferOrView subtypes r=jonco
https://hg.mozilla.org/integration/autoland/rev/fc845975e3cd
Change Heap<T> constructors to accept non-default-constructible T r=jonco
https://hg.mozilla.org/integration/autoland/rev/551bd2292b5c
Move SafelyInitialized into a struct to allow partial specialization. r=jonco
https://hg.mozilla.org/integration/autoland/rev/c795c0db74aa
Augment the WrappedPtrOperations for ArrayBufferOrView subclasses. r=jonco
https://hg.mozilla.org/integration/autoland/rev/500b9492fa23
Implement Heap<ArrayBufferOrView> (for all subtypes) r=jonco

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/1937d943bc78
https://hg.mozilla.org/mozilla-central/rev/fc845975e3cd
https://hg.mozilla.org/mozilla-central/rev/551bd2292b5c
https://hg.mozilla.org/mozilla-central/rev/c795c0db74aa
https://hg.mozilla.org/mozilla-central/rev/500b9492fa23