1736825 - Improve the parsing of `manifest.json` files in `browser/base/content/test/static/browser_all_files_referenced.js` to support built-in add-ons

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P2)

Description

[William Durand [:willdurand]]

Instead of adding new entries in the exclusion list when this test case fails because of a built-in add-on, we should improve the parseJsonManifest() function as described in https://phabricator.services.mozilla.com/D128908#4192312

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1736825 - Improve manifest.json files parsing in browser_all_files_referenced.js. r?florian!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b265817ccc60
Improve manifest.json files parsing in browser_all_files_referenced.js. r=florian

Comment 3

[Iulian Moraru]

Backed out for causing mochitests browser chrome failures on browser_startup_syncIPC.js.

Push with failures

Failure log

Backout link

Comment 4

[Florian Quèze [:florian]]

(In reply to Iulian Moraru from comment #3)

Backed out for causing mochitests browser chrome failures on browser_startup_syncIPC.js.

Push with failures

Failure log

This comes with a profile that shows https://share.firefox.dev/30Me0GL the PGPU::Msg_AddLayerTreeIdMapping sync IPC happens while styling for the first time a dummy.xhtml document created during WEBEXT_BACKGROUND_PAGE_LOAD_MS_BY_ADDONID:[e-mail]

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

The failure was actually triggered by the other patch landed along with this one in the same push (Bug 1735721), and unrelated to the changes in the patch attached to this bug (which can re-land without any additional change).

Nonetheless, Florian pointers from comment 4 were very useful to better understand the failure triggered by Bug 1735721.

We (Florian and I) also discussed further about the failure over Matrix and agreed on what to change in the short run to workaround the test failure as part of Bug 1735721 patch, and then as a separate follow up to try to resume the work on Bug 1582788 (because that would be the actual long term solution).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33304706b8b5
Improve manifest.json files parsing in browser_all_files_referenced.js. r=florian

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/33304706b8b5

Comment 8

[Acasandrei Beatrice (needinfo me)]

Hello. This bug or Bug 1735721 has caused this regression. Can you please help with identifying which one might be the cause?

Comment 9

[William Durand [:willdurand]]

This bug cannot be the cause of the regression. It's very likely the other one.