HelperThreads: Schedule IonCompile task last when no JS is executed.
Categories
(Core :: JavaScript Engine, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox96 | --- | fixed |
People
(Reporter: nbp, Assigned: nbp)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Currently, IonCompile tasks are schedule quite high in our priority list of helper thread.
This can be a problem as IonCompile task can last quite a long time.
While IonCompile task should remain a priority when we are executing JS code, these should no longer be considered a priority when no JS code is executing. When no JS code is being executed, we should prioritize ParseTask and WasmTier1 tasks, as these are the one which would most likely to be blocking upcoming code execution.
|
Assignee | |
Comment 1•3 years ago
|
||
This modification makes the hypothesis that we should not be prioritizing the
compilation with our optimizing compiler while we could have scripts which are
pending to be parsed.
This patch resolve this issue by adding a flag to query whether the thread for
which the Ion compilation is schedule has some JS on its stack. Otherwise, it
will schedule Ion compilations after having parsed all scripts which are waiting
to be parsed.
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
Pushed by npierron@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ecf3b04a681c Reduce IonCompilation priority when no JS is executed. r=jandem
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Description
•