1736968 - Add "mozalloc_abort" crash reason to distinguish mozalloc_abort() and bare MOZ_CRASH() crashes

Status: RESOLVED FIXED

(Core :: MFBT, task, P3)

Description

[Chris Peterson [:cpeterson]]

About 45% of MOZ_CRASH() crash pings on Beta (and 5-10% on Nightly and Release) have no crash reason, so the source can't be identified. Many of these are probably OOMs calling mozalloc_abort(), but we don't really know.

Bug 1278613 suggested passing mozalloc_abort()'s message parameter to MOZ_CRASH() or MOZ_CRASH_UNSAFE(), but there were concerns about the message containing PII or formatting the message after an OOM might crash.

Until someone addresses those concerns, we can at least add a static "mozalloc_abort" crash reason to distinguish mozalloc_abort() and bare MOZ_CRASH() crashes.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1736968 - Pass mozalloc_abort() crash reason to MOZ_CRASH() to distinguish mozalloc_abort() and bare MOZ_CRASH() crashes. r?glandium

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: Bug 1736968 - Change MOZ_CRASH() to MOZ_ASSUME_UNREACHABLE_MARKER() for abort()'s ARM noreturn case. r?glandium

This extra MOZ_CRASH() is not needed on non-ARM builds where mozalloc_abort() is a MOZ_NORETURN function.

Depends on D129114

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dee2e7821994
Pass mozalloc_abort() crash reason to MOZ_CRASH() to distinguish mozalloc_abort() and bare MOZ_CRASH() crashes. r=glandium
https://hg.mozilla.org/integration/autoland/rev/2f3b5d0ef911
Change MOZ_CRASH() to MOZ_ASSUME_UNREACHABLE_MARKER() for abort()'s ARM noreturn case. r=glandium

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/dee2e7821994
https://hg.mozilla.org/mozilla-central/rev/2f3b5d0ef911