1737054 - HCM hover state on shield/lock does not match page actions

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Harry Twyford]

As of bug 1735643, the Urlbar page actions invert their colors when hovered in High Contrast Mode. Specifically, they use SelectedItem/SelectedItemText for their colours. The shield and lock icon don't yet use those colors on hover.

Comment 1

[Harry Twyford]

These two lines should be replaced with

  background-color: var(--urlbar-box-hover-bgcolor);
  color: var(--urlbar-box-hover-text-color);

and

  background-color: var(--urlbar-box-active-bgcolor);
  color: var(--urlbar-box-hover-text-color);

respectively. See the patch in bug 1735643 for examples of similar changes.

Comment 2

[Leslie]

Attachment: Bug 1737054-HCM hover state on shield/lock does not match page actions. r?harry

Comment 3

[ola-oluwa]

Hi harry if you don't mind helping with more details i would love to work on this

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b08b5e664b36
HCM hover state on shield/lock does not match page actions. r=harry,desktop-theme-reviewers

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b08b5e664b36

Comment 6

[Dão Gottwald [:dao]]

Attachment: Bug 1737054 - add missing semicolon. r=harry

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac27da59cf34
add missing semicolon. r=harry

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/ac27da59cf34

Comment 9

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed using the latest Fx98.0a1 and Fx97.0b1 on Windows 10 and Ubuntu 20.04. The shield and lock buttons have the correct hover color in high contrast mode.