1737089 - SanitizeRenderer.cpp: the 'empty' method should be used to check for emptiness instead of 'size'

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

if (archLetter.size()) {
should use .empty() instead

https://searchfox.org/mozilla-central/source/dom/canvas/SanitizeRenderer.cpp#119

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-container-size-empty.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Tawah Peggy]

Attachment: Bug 1737089 - Replace size() with empty(). r=Sylvestre

SanitizeRenderer.cpp: The empty method should be used to check for emptiness instead of the size method.

Depends on D130540

Comment 2

[Tawah Peggy]

Hello Sylvestre.
please help me review this change and let me know if there are any issues.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

As andi said, please rebase your patch: it doesn't apply :)
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Comment 4

[Sylvestre Ledru [:Sylvestre]]

actually, it was the other patch in your stack. :)
you can ignore my message

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b72647a71c3d
Replace size() with empty(). r=sylvestre

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b72647a71c3d