1737097 - transportlayerdtls.cpp: the 'empty' method should be used to check for emptiness instead of 'size'

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

MOZ_ASSERT(digests_.size() != 0);
should use .empty() instead

https://searchfox.org/mozilla-central/rev/489e82dcc1e5afbe691ff3b1c982382914637e38/dom/media/webrtc/transport/transportlayerdtls.cpp#1444

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-container-size-empty.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[vishal]

Attachment: Bug 1737097 - use .empty() instead of size() r=sylvestre

Depends on D129803

Comment 2

[vishal]

Need review

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Quick feedback: please be patient and ask politely ;)

Comment 4

[vishal]

Sorry,

Comment 5

[vishal]

Attachment: Bug 1737097 fix mistake r?Sylvestre

Depends on D129854

Comment 6

[vishal]

Please review my patch.
Thanks

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40f6400ae8b1
use .empty() instead of size() r=sylvestre

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/40f6400ae8b1