1737098 - DrawTargetSkia.cpp: the 'empty' method should be used to check for emptiness instead of 'size'

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

MOZ_ASSERT(mPushedLayers.size());
should use .empty() instead

https://searchfox.org/mozilla-central/rev/489e82dcc1e5afbe691ff3b1c982382914637e38/gfx/2d/DrawTargetSkia.cpp#1826

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-container-size-empty.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Tawah Peggy]

Attachment: Bug 1737098 - replace size() with empty().r?Sylvestre Ledru.

DrawTargetSkia.cpp:the 'empty' method should be used to check for emptiness instead of size

Depends on D129718

Comment 2

[Tawah Peggy]

Hello Sylvestre,
please I would appreciate if you can help me review this.
thanks,
Peggy

Comment 3

[sirri]

Attachment: Bug 1737098 - replace size() with empty() r?sylvestre

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9af56301448a
replace size() with empty() r=sylvestre

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/9af56301448a