Closed Bug 1737112 Opened 4 years ago Closed 4 years ago

Instruction for adding git-cinnabar to PATH uses "c:/" style but it should use "/c/" style

Categories

(Firefox Build System :: Bootstrap Configuration, defect, P3)

defect

Tracking

(firefox96 fixed)

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: arai, Assigned: ahochheiden)

References

Details

Attachments

(1 file)

Similar to bug 1737042, but more critical.

On windows, running bootstrap with git repository shows the following at the end.
there it uses "c:/" style path, but ":" is delimiter between paths in PATH env, and you cannot use it there.

To add git-cinnabar to the PATH, edit your shell initialization script, which
may be called ~/.bashrc or ~/.bash_profile or ~/.profile, and add the following
lines:
​
    export PATH="c:/Users/USER/.mozbuild\git-cinnabar:$PATH"
​
Then restart your shell.

it should say

    export PATH="/c/Users/USER/.mozbuild\git-cinnabar:$PATH"
Assignee: nobody → ahochheiden
Status: NEW → ASSIGNED
Priority: -- → P3

Updated the path value in the instructions from "<drive>:/" to "/drive/" for
Windows so that it works as intended when added to the MSYS profile. Also
added a copyable link to the expected msys/etc dir based on the MOZILLABUILD
environment variable to direct the user to where to apply the change.

(If the MOZILLABUILD variable isn't defined, supply the expected default instead)

Attachment #9247704 - Attachment description: Bug 1737112 - Update instructions for adding git-cinnabar to PATH on Windows r=mhentges, g=firefox-build-system-reviewers → Bug 1737112 - Update instructions for adding git-cinnabar to PATH on Windows r=mhentges g=firefox-build-system-reviewers
Pushed by mhentges@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/362251834a83 Update instructions for adding git-cinnabar to PATH on Windows r=mhentges,firefox-build-system-reviewers,glandium g=firefox-build-system-reviewers
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: