1737180 - Enable compositor animation when using scroll-timeline

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, enhancement, P3)

Description

[Boris Chiou [:boris]]

Bug 1676791 disables compositor animations when we use scroll-timeline. We should enable it and let compositor animations use scroll information.

Comment 1

[Boris Chiou [:boris]]

Copied from Matrix (from Hiro):

Since bug 1571758, scroll-linked animations on the compositor will be complicated because now on the sampler thread APZ hasn't yet determined scroll positions, it defers to the web render rendering thread. So suppose scroll linked animations need to be calculated there.

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1737180 - Part 3: Sample scroll-linked animations based on the apz scroll offsets.

Debug version.

Comment 3

[Boris Chiou [:boris]]

Attachment: Bug 1737180 - Part 1: Populate scroll timeline information when adding animations for webrender

We use the struct, ScrollTimelineOptions, and two fields to represent the
information which will be sent to the compositor thread.

Comment 4

[Boris Chiou [:boris]]

Attachment: Bug 1737180 - Part 2: Populate scroll timeline information when adding animations for webrender.

And extract this information on the compositor thread. We will use it
in the following patches.

Comment 5

[Boris Chiou [:boris]]

Attachment: Bug 1737180 - Part 2: Move the calculation of elapsed duration into a static function.

Comment 6

[Boris Chiou [:boris]]

Attachment: Bug 1737180 - Part 4: Enable OMTA for scroll animations.

And update the related tests as well.

Comment 7

[Boris Chiou [:boris]]

Attachment: Bug 1737180 - Part 4: Minor optimization for OMTA sampling if there is no scroll animation.

We don't have to lock APZCTreeManager::mMapLock if there is no scroll animation.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e114245b4cec
Part 1: Populate scroll timeline information when adding animations for webrender r=hiro
https://hg.mozilla.org/integration/autoland/rev/3f30c9187a6d
Part 2: Move the calculation of elapsed duration into a static function. r=hiro
https://hg.mozilla.org/integration/autoland/rev/93cb779a267c
Part 3: Sample scroll-linked animations based on the apz scroll offsets. r=hiro,botond
https://hg.mozilla.org/integration/autoland/rev/424f9d2ca137
Part 4: Enable OMTA for scroll animations. r=hiro

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e114245b4cec
https://hg.mozilla.org/mozilla-central/rev/3f30c9187a6d
https://hg.mozilla.org/mozilla-central/rev/93cb779a267c
https://hg.mozilla.org/mozilla-central/rev/424f9d2ca137