1737263 - Pages containing SVG images are unsuccessfully printed

Status: REOPENED

(Core :: Graphics, defect)

Description

[Giorgia Nichita, Release Desktop QA]

Attachment: RC.cgi.pdf

Affected versions

• Latest Nightly 95.0a1
• Beta 94.0b9
• RC 93.0

Affected platforms

• Windows 10x64
• Ubuntu 20.04
• macOS 10.15

Steps to reproduce

1. Launch Firefox.

2. Access the following link: https://bug1715803.bmoattachments.org/attachment.cgi?id=9226355.

3. Print preview the page.

4. Save the page as PDF.

5. Compare it with print preview.

Expected result

• The Save to PDF page looks like in the print preview.

Actual result

• The Save to PDF page adds unwanted background to the image.

Suggested Severity

• S3 since it only affects certain extensions

Regression range

• This is not a recent regression since is reproduces on 93.0 Release. I will look for an old regression range as soon as possible.

Additional notes

• I attached a Print to file PDF with the problem.
• On macOS 10.15 the issue is more visible. The image is completely ruined.

Comment 1

[Alice0775 White]

There are two regression.

#1 Regression window(Some of the lines and curves in the graphic are missing):
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2b3545abbf55f49144afae64bd9ac4b75d28d817&tochange=c7cb63e184710abd9c54d813504a2cffcd1bd12f

#2 Regression window(Completely blank):
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d16750799f8a8642c95dadcff2ab098aacf7d8fa&tochange=a2af18ebbe6e043e4b0acf958baca829bdb79bc4

Comment 2

[Jim Mathies [:jimm]]

Hey Jeff, a couple regressions from Matt's work. You reviewed it, so wondering if you might have some ideas.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Yeah, I'll take a look

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1737263. Switch back to PushLayerWithBlend.

Bug 1540737 originally used PushLayerWithBlend here but
PushLayerWithBlend is not implemented for D2D. Since then,
I believe we've stopped using D2D for content drawing so
it should be possible to switch back to PushLayerWithBlend.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4053cb4ba9ad
Switch back to PushLayerWithBlend. r=mstange

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4053cb4ba9ad

Comment 7

[Giorgia Nichita, Release Desktop QA]

Attachment: SVGimage.png

Verified as fixed on Ubuntu 20.04 and Windows 10x64 on the latest Nightly 96.0a1 (20211105093421).

On macOS it looks a lot better, but the image is blurry. I attached a screenshot with the issue.
@Jeff, do you know if this is expected or should I fill a new bug for this issue?

Comment 8

[Jeff Muizelaar [:jrmuizel]]

(In reply to Giorgia Nichita, Release Desktop QA from comment #7)

Created attachment 9249429 [details]
SVGimage.png

Verified as fixed on Ubuntu 20.04 and Windows 10x64 on the latest Nightly 96.0a1 (20211105093421).

On macOS it looks a lot better, but the image is blurry. I attached a screenshot with the issue.
@Jeff, do you know if this is expected or should I fill a new bug for this issue?

Giorgia can you check what the behaviour was on macOS before bug 1540737 landed?

Comment 9

[Atila Butkovits]

Backed out for causing Windows graphics crashes (bug 1739661)

Backout link: https://hg.mozilla.org/integration/autoland/rev/2d244932aec645578e28d2572eaef0a4fb7b8ff4

Comment 10

[Alexandru Michis [:malexandru]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/2d244932aec645578e28d2572eaef0a4fb7b8ff4

Comment 11

[Giorgia Nichita, Release Desktop QA]

Attachment: Screenshot 2021-11-08 at 12.54.11.png

(In reply to Jeff Muizelaar [:jrmuizel] from comment #8)

Giorgia can you check what the behaviour was on macOS before bug 1540737 landed?

Before Bug 1540737 landed, the image was completely ruined, I attached a screenshot of the behavior.

Comment 12

[BugBot [:suhaib / :marco]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jrmuizel, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 13

[Andrei Vaida [:avaida]]

Desktop QA has been highlighting this defect as a known issue for several release cycles now, following regression testing. Bob, it would really help us if you set a priority on this bug — it will give us clarity on whether this issue is still worth mentioning in future test reports.