[wpt-sync] Sync PR 31359 - Make targetted-form.js's populateForm() deal better with being re-ent…
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox95 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 31359 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/31359
Details from upstream follow.
Chris Dumez <cdumez@apple.com> wrote:
Make targetted-form.js's populateForm() deal better with being re-ent…
…ered
In WebKit, calling
document.body.insertAdjacentHTML()
to insert in <iframe> will
load the initial empty document synchronously and finish parsing, which will perform
a microtask checkpoint. Because of this checkpoint, one of the other promise tests in
html/semantics/forms/form-submission-0/form-submission-algorithm.html may run and
call populateForm() again. populateForm() was not safe to re-enter because of its
frameCounter
variable that was used in insertAdjacentHTML() but only incremented
after. Similarly,document.body.firstChild.nextSibling
would not return the right
form since a new frame/form may have been prepended to the <body> when re-entering.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e20594e4de7599fd15182f7c24acb2f23c51f6a
Assignee | ||
Comment 2•3 years ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 7 tests and 9 subtests
Status Summary
Firefox
OK : 7
PASS : 33
FAIL : 6
Chrome
OK : 7
PASS : 39
Safari
OK : 6
PASS : 16
FAIL : 23
ERROR: 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
Firefox-only Failures
/custom-elements/form-associated/form-disabled-callback.html
A disabled form-associated custom element should not provide an entry for it: FAIL
New Tests That Don't Pass
/custom-elements/form-associated/form-disabled-callback.html
Adding/removing disabled content attribute: FAIL (Chrome: PASS, Safari: FAIL)
Relationship with FIELDSET: FAIL (Chrome: PASS, Safari: FAIL)
A disabled form-associated custom element should not provide an entry for it: FAIL (Chrome: PASS, Safari: PASS)
A disabled form-associated custom element should not submit an entry for it: FAIL (Chrome: PASS, Safari: FAIL)
Disabled attribute affects focus-capability: FAIL (Chrome: PASS, Safari: FAIL)
Upgrading an element with disabled content attribute: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2b2a2381e547 [wpt PR 31359] - Make targetted-form.js's populateForm() deal better with being re-ent…, a=testonly
Comment 4•3 years ago
|
||
bugherder |
Description
•