1737313 - Fix & improve Angle so it can run in mach vendor / updatebot

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Tom Ritter [:tjr]]

It is difficult to rename or alias the python3 binary that is pre-installed on our Windows taskcluster images, so I am hoping it won't be disruptive if I make this small change to the update-angle script, Jeff.

Edit: This bug is being expanded 11/30. I'm breaking out the parent bug into some sub-bugs so there aren't a ton of patches on a single bug. This bug is for improvements to angle so it can run in mach vendor and updatebot.

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1737313: Rename py -> python3 in update-angle r?jgilbert

Comment 2

[Tom Ritter [:tjr]]

Attachment: Bug 1737313 - Add the License file from Angle which I couldn't find in-tree r?jgilbert

Depends on D129285

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:tjr, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Tom Ritter [:tjr]]

I'm holding out on landing this until I have it working end-to-end. Currently beating my head against the wall...

Comment 5

[Tom Ritter [:tjr]]

Attachment: Bug 1737313: Implement a wrapper around update-angle.py r?jewilde

This will set up all of the env vars that are needed for running
update-angle, and also grab the angle repo, set it up and run the
update

Comment 6

[Tom Ritter [:tjr]]

Attachment: Bug 1737313: Switch Angle over to the new angle-type source hosting r?jewilde,jgilbert

Depends on D129435

Comment 7

[Tom Ritter [:tjr]]

Attachment: Bug 1737313: Pass the correct revision to update angle to r?jewilde

Comment 8

[Tom Ritter [:tjr]]

Attachment: Bug 1737313: Document what is needed to generate a preloaded depot_tools zip r?#build

Depends on D129536

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41cc41a6eff7
Rename py -> python3 in update-angle r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/0f18059b15a6
Add the License file from Angle which I couldn't find in-tree r=jgilbert

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/41cc41a6eff7
https://hg.mozilla.org/mozilla-central/rev/0f18059b15a6

Comment 11

[Takanori MATSUURA]

Missing "leave-open"?

Comment 12

[Tom Ritter [:tjr]]

Thanks; should be closed by the next landing

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c08f3298082d
Implement a wrapper around update-angle.py r=jewilde,jgilbert
https://hg.mozilla.org/integration/autoland/rev/e619e8173457
Pass the correct revision to update angle to r=jewilde,jgilbert
https://hg.mozilla.org/integration/autoland/rev/93290e795ab0
Switch Angle over to the new angle-type source hosting r=jgilbert,jewilde
https://hg.mozilla.org/integration/autoland/rev/36cd6aeb635f
Document what is needed to generate a preloaded depot_tools zip r=firefox-build-system-reviewers,glandium

Comment 14

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/c08f3298082d
https://hg.mozilla.org/mozilla-central/rev/e619e8173457
https://hg.mozilla.org/mozilla-central/rev/93290e795ab0
https://hg.mozilla.org/mozilla-central/rev/36cd6aeb635f