1737605 - Incorrect error message when AutoLaunchProtocolFromOrigins is not an origin

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect, P3)

Description

[Mike Kaply [:mkaply]]

If you specify a host instead of an origin for AutoLaunchProtocolFromOrigins you get the error:

Added by default for protocol handler - undefined.

We should show the correct error.

Also we should see if we can show the policy that's being processed in the error.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1737605 - Parse JSON directly from GPO so it's properly validated. r?mstriemer,mtigley

Comment 2

[Mike Kaply [:mkaply]]

Definitely want QA when this goes in since we can't automated test.

Basically it's going to be making sure the policies that use JSON still work via GPO:

AutoLaunchProtocolsFromOrigins
ExtensionSettings
Handlers
ManagedBookmarks
Preferences

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7ec28ed7098
Parse JSON directly from GPO so it's properly validated. r=mtigley

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/f7ec28ed7098

Comment 5

[Mike Kaply [:mkaply]]

Comment on attachment 9248281 [details]
Bug 1737605 - Parse JSON directly from GPO so it's properly validated. r?mstriemer,mtigley

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Parity with 96, policy specific
• User impact if declined: Unable to verify errors with certain policies
• Fix Landed on Version: 96
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Has been on trunk with no issues. Unable to have automated test due to registry stuff.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9248281 [details]
Bug 1737605 - Parse JSON directly from GPO so it's properly validated. r?mstriemer,mtigley

Approved for 91.5esr.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/afe1ed31b5fc

Comment 8

[Emil Ghitta, QA [:emilghitta]]

Verified that the following policies which use JSON are working if enabled/configured via GPO:

AutoLaunchProtocolsFromOrigins
ExtensionSettings
Handlers
ManagedBookmarks
Preferences

Verification was performed using Firefox 96.0b8 (BuildId:20211221185759) and Firefox 91.5.0esr (provided in comment 7) on Windows 10 64bit.