Closed Bug 1737699 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31381 - Update Sec-CH-UA tests: fix existing tests, and test brand size.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox95 fixed)

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31381 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31381
Details from upstream follow.

Mike Taylor <miketaylr@chromium.org> wrote:

Update Sec-CH-UA tests: fix existing tests, and test brand size.

As of https://github.com/WICG/ua-client-hints/issues/179,
https://wicg.github.io/ua-client-hints/#user-agent-brand now requires
that a brand in a brand list not be longer than 32 bytes.

This CL adds a new test for the userAgentData.brands interface, and
modifies the existing sec-ch-ua HTTP tests.

Also, the existing sec-ch-ua HTTP tests were updated to more closely
reflect the current state of UA-CH ("UA" is not a valid token, and
"Accept-CH-Lifetime" is not shipping).

Bug: 1263180
Change-Id: Ifa7cbf18d67271e2dd1dc1d485f432d4ca9327fa
Reviewed-on: https://chromium-review.googlesource.com/3243544
WPT-Export-Revision: f8d5c8f278e0a348381249b77133ccd0ff9fc580

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 1 subtests

Status Summary

Firefox

OK : 4
PASS: 1
FAIL: 5

Chrome

OK : 4
PASS: 6

Safari

OK : 4
PASS: 1
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/ua-client-hints/useragentdata.https.any.worker.html
tests for navigator.userAgentData: FAIL (Chrome: PASS, Safari: FAIL)
/client-hints/sec-ch-ua.https.html
Open HTTPS window: Sec-CH-UA header returned by default.: FAIL (Chrome: PASS, Safari: FAIL)
Open HTTPS window: Sec-CH-UA header is consistent across versions.: FAIL (Chrome: PASS, Safari: FAIL)
Open HTTPS window: No brand in Sec-CH-UA header is > than 32 chars.: FAIL (Chrome: PASS, Safari: FAIL)
/ua-client-hints/useragentdata.https.any.html
tests for navigator.userAgentData: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4b3902d05970
[wpt PR 31381] - Update Sec-CH-UA tests: fix existing tests, and test brand size., a=testonly
https://hg.mozilla.org/integration/autoland/rev/3158a50a85bb
[wpt PR 31381] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/4b3902d05970
https://hg.mozilla.org/mozilla-central/rev/3158a50a85bb

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.