1737704 - Re-enable hunspell rlbox sandbox on 32 bit platforms

Status: RESOLVED FIXED

(Core :: Spelling checker, defect, P3)

Comment 1

[Shravan Narayan]

Attachment: Bug 1737704 - Re-enable hunspell rlbox sandbox on 32 bit platforms r=glandium

Comment 2

[Bobby Holley (:bholley)]

The main thing we need to figure out here is the crash in bug 1736171. We're reenabling for one cycle with some new diagnostics in bug 1738095 to try to understand that crash better.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b11349b0406f
Re-enable hunspell rlbox sandbox on 32 bit platforms r=glandium

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/b11349b0406f

Comment 5

[Bobby Holley (:bholley)]

Comment on attachment 9247662 [details]
Bug 1737704 - Re-enable hunspell rlbox sandbox on 32 bit platforms r=glandium

Beta/Release Uplift Approval Request

• User impact if declined: We're aiming to make a splash by shipping three sandboxed libraries across all platforms in 95. This is all on beta, except that hunspell sandboxing was disabled on 32-bit platforms due to crashes in the wild. We found and fixed the crash in bug 1736171, and the fix landed before the 95 train merged to beta. However, I wanted to let the re-enable bake on Nightly for a few days to verify that the crashes did not resurface. I have confirmed that's the case, so I'd like to uplift this.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Functionality is already enabled on beta for most platforms, and was disabled on 32-bit due to a crash that we've now fixed.
• String changes made/needed:

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9247662 [details]
Bug 1737704 - Re-enable hunspell rlbox sandbox on 32 bit platforms r=glandium

Approved for 95 beta 3, thanks.

Comment 7

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/b4e3132c24da

Comment 8

[Narcis Beleuzu [:NarcisB]]

Backed out for causing Bug 1739669

Backout link: https://hg.mozilla.org/releases/mozilla-beta/rev/02164a5c9bd22634590e82395f3e73b321b1fc24

Comment 9

[Bobby Holley (:bholley)]

This was only backed out on beta right? So shouldn't status-firefox96 remain affected, and this bug remain RESOLVED FIXED?

Comment 10

[Narcis Beleuzu [:NarcisB]]

Yes. It was backed out only from beta

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9247662 [details]
Bug 1737704 - Re-enable hunspell rlbox sandbox on 32 bit platforms r=glandium

Clearing the Beta approval to get this off the needs-uplift radar.

Comment 12

[Pascal Chevrel:pascalc]

Comment on attachment 9247662 [details]
Bug 1737704 - Re-enable hunspell rlbox sandbox on 32 bit platforms r=glandium

Needed for bug 1740974

Comment 13

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/043912bd98bf

Comment 14

[Shravan Narayan]

I'm keeping an eye on the beta to make sure this patch sticks.