Closed Bug 1737824 Opened 3 years ago Closed 3 years ago

Allow calling GeckoSession::load from any thread

Categories

(GeckoView :: General, defect, P1)

Unspecified
All
defect

Tracking

(firefox97 fixed)

RESOLVED FIXED
97 Branch
Tracking Status
firefox97 --- fixed

People

(Reporter: agi, Assigned: agi)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [geckoview:m97])

Attachments

(1 file)

GeckoSession::load is marked as @AnyThread but when a consumer tries to call it on a thread without a looper we fail. For details see Bug 1712784.

We should allow consumers to call load from any thread.

Priority: -- → P1
Whiteboard: [geckoview:m96]
Priority: P1 → P2
Whiteboard: [geckoview:m96] → [geckoview:m97?]
Whiteboard: [geckoview:m97?] → [geckoview:m97]
Priority: P2 → P1

Normally we always want GeckoResult callbacks to run in the same thread where
the GeckoResult has been created.

In the case where we don't have a looper, however, we cannot do that. For
delegate calls, we are going to send the call to the UI thread, so we can use
the UI thread to run the callback (which is what the embedder would have to do
in this case, anyway).

Assignee: nobody → agi
Status: NEW → ASSIGNED
Pushed by asferro@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/454638da3ee4 Allow running GeckoSession::load from any thread. r=jonalmeida
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: