1737842 - [wpt-sync] Sync PR 31383 - Fix crash with unsupported keyframe effect options.

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 31383 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31383
Details from upstream follow.

Kevin Ellis <[e-mail]> wrote:

Fix crash with unsupported keyframe effect options.

Animation::Create can throw and exception or return nullptr. This method
is called from AnimationTimeline::Play, which was implicitly asserting
that no exception is thrown and checks that the animation was created.
These assumptions resulted in a crash when the effect timing options
contain unsupported values.

Bug: 1245487
Change-Id: I39afd196c9881754ebed5f1d7c4d37027c2ec147

Reviewed-on: https://chromium-review.googlesource.com/3245202
WPT-Export-Revision: fbe673ceabac6dc842870e8c8d23d99d5b1f5b22

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=72adba85aaae7414933b37754750cd14c00bbc1a

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1

Chrome

CRASH: 1

Safari

PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/469b3cf37c73
[wpt PR 31383] - Fix crash with unsupported keyframe effect options., a=testonly

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/469b3cf37c73