1737969 - Remove lodash findIndex usage

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

https://searchfox.org/mozilla-central/search?q=findIndex.*+from+%22lodash&path=devtools%2Fclient%2Fdebugger%2F&case=false&regexp=true

We should be able to replace it with frames.findIndex

Comment 1

[Clinton]

Seems like something I can work on would love to take it up if that's okay.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Sure, it's yours Clinton :)

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Clinton, do you still plan to work on this?

Comment 4

[Clinton]

Yes, Sorry I took an extended sabbatical. I expect to get back to this by next week. Happy new year!

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Clinton from comment #4)

Yes, Sorry I took an extended sabbatical. I expect to get back to this by next week. Happy new year!

no worries, happy new year to you too :)

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1737969 - [devtools] Remove lodash findIndex/findLastIndex usages. r=jdescottes.

We take this opportunity to rename removeInnerLocations to getInnerLocations
and make it return an array of inner locations rather than returning the list
of original locations with inner locations stripped.
This makes the function easier to understand (not having to deal with indexes

• splicing), and doesn't harm the only callsite where we can handle those inner
  locations into the filter call that was done on the array returned from removeInnerLocations

The parser-worker was updated.

Depends on D136094

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c0b2b6e998d
[devtools] Remove lodash findIndex/findLastIndex usages. r=jdescottes.

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/7c0b2b6e998d