Closed Bug 1737980 Opened 3 years ago Closed 2 years ago

Remove lodash omit usage

Categories

(DevTools :: Debugger, task)

task

Tracking

(firefox98 fixed)

RESOLVED FIXED
98 Branch
Tracking Status
firefox98 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/reducers/expressions.js#103

Here we can probably replace this with the spread operator + delete

prefs.expressions = expressions.map(expression => {
  const expressionWithoutValue = {...expression};
  delete expressionWithoutValue.value;
  return expression;
})

It was only used in storeExpressions, where we can replace it by storing only the input property
instead of removing the value property from the object we store.

Depends on D136096

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f0e1f377dd9e
[devtools] Remove lodash omit usage. r=bomsy.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: