Closed
Bug 1737983
Opened 4 years ago
Closed 4 years ago
Remove lodash `remove` usage
Categories
(DevTools :: Debugger, task)
DevTools
Debugger
Tracking
(firefox97 fixed)
RESOLVED
FIXED
97 Branch
Tracking | Status | |
---|---|---|
firefox97 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: bubuanabelas)
References
Details
(Keywords: good-first-bug)
Attachments
(2 files)
1.12 KB,
patch
|
Details | Diff | Splinter Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
This can probably be replaced with a loop
Assignee | ||
Comment 1•4 years ago
|
||
I think this should do it but could run the tests to see if anything breaks down
Reporter | ||
Comment 2•4 years ago
|
||
It looks good to me Joaquín!
Can you please follow https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#to-submit-a-patch to properly submit the patch for review? You can add me as a reviewer (put r=nchevobbe
at the end of the first line of your commit message).
Thanks
Assignee: nobody → bubuanabelas
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•4 years ago
|
||
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/27c12803c96b
Remove lodash `remove` usage r=nchevobbe
Comment 5•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox97:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•