1738004 - [wpt-sync] Sync PR 31398 - Revert "[LCP] Add animated image support"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 31398 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31398
Details from upstream follow.

Mikel Astiz <[e-mail]> wrote:

Revert "[LCP] Add animated image support"

This reverts commit b7d510c06e0436cfb4bd7260175cd460b949225c.

Reason for revert: speculative revert for new flakiness in
PageLoadMetricsBrowserTestWithAnimatedLCPFlag, see first failing
build
https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/99853

Original change's description:

[LCP] Add animated image support

This CL adds support for better handling of animated images in LCP:

• A new attribute is exposing the first animated frame's paint time
  (behind a flag).
• startTime is not changed.
• The PageLoadMetrics reported for LCP are set to that first frame paint
  time for animated images (behind another flag).
• Entries are not emitted until the image is loaded.

Relevant spec issue:
https://github.com/WICG/largest-contentful-paint/issues/83

Change-Id: I6bb01eacb4f200f9c032ffcfcd9a1a41126a7773
Bug: 1260953
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226157
Commit-Queue: Yoav Weiss \<[e-mail]>
Reviewed-by: Nicolás Peña Moreno \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#935133}

Bug: 1260953
Change-Id: I00878689de95de38645195da81c6baf577d868a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3247071
Auto-Submit: Mikel Astiz \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Commit-Queue: Mikel Astiz \<[e-mail]>
Owners-Override: Mikel Astiz \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#935350}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 31398 applied with additional changes from upstream: 8c690c8980d38fc3c01d8d9a284367401dec4fb3

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9cfaf89443b96743286bae0cc566ea313de325e8

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 24 tests and 1 subtests

Status Summary

Firefox

OK : 24
FAIL: 24

Chrome

OK : 24
PASS: 22
FAIL: 2

Safari

OK : 24
FAIL: 24

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/largest-contentful-paint/contracted-image.html
Largest Contentful Paint: |size| attribute is bounded by display size.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/cross-origin-image.sub.html
Cross-origin image is observable, with renderTime equal to 0.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/expanded-image.html
Largest Contentful Paint: |size| attribute is bounded by intrinsic size.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/first-letter-background.html
Largest Contentful Paint: first-letter is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/image-TAO.sub.html
Cross-origin elements with valid TAO have correct renderTime, with invalid TAO have renderTime set to 0.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/image-full-viewport.html
The intersectionRect of an img element overflowing is computed correctly: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/image-inside-svg.html
Image inside SVG is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/image-not-fully-visible.html
The intersectionRect of an img element overflowing is computed correctly: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/image-removed-before-load.html
Largest Contentful Paint: image removed before loaded does not produce entry.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/image-src-change.html
Largest Contentful Paint: changing src causes a new entry to be dispatched.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/larger-image.html
Largest Contentful Paint: largest image is reported.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/loadTime-after-appendChild.html
Image loadTime occurs after appendChild is called.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/multiple-redirects-TAO.html
Cross-origin images with passing/failing TAO should/shouldn't have its renderTime set.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/observe-after-untrusted-scroll.html
Same-origin image after a JS initiated scroll event is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/observe-image.html
Same-origin image is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/observe-svg-background-image.html
Same-origin SVG background image is observable.: FAIL (Chrome: FAIL, Safari: FAIL)
/largest-contentful-paint/observe-svg-data-uri-background-image.html
Data-URI background SVG image is observable.: FAIL (Chrome: FAIL, Safari: FAIL)
/largest-contentful-paint/observe-svg-data-uri-image.html
Same-origin image is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/observe-svg-image.html
Same-origin image is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/placeholder-image.html
Largest Contentful Paint: changing src causes a new entry to be dispatched.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/redirects-tao-star.html
Cross-origin image without TAO should not have its renderTime set, with full TAO it should.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/repeated-image.html
Repeated image produces different timestamps.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/same-origin-redirects.html
Same-origin image redirect without TAO should have its renderTime set.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/video-poster.html
Able to observe a video's poster image.: FAIL (Chrome: PASS, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34e9fd51423c
[wpt PR 31398] - Revert "[LCP] Add animated image support", a=testonly

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/34e9fd51423c