1738020 - Clean up reshaping for shape teleporting

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jan de Mooij [:jandem]]

We can tidy up the shape teleporting code a bit to prepare for future changes.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1738020 part 1 - Check for shadowing properties from addProperty and addCustomDataProperty. r?tcampbell!

We only need to call ReshapeForShadowedProp when adding a new property to the shape,
but we were also calling it when changing an existing property or when we call a
defineProperty hook.

Moving the call into addProperty/addCustomDataProperty is both more efficient and simpler.
This is also preparing for future invalidation-related changes.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1738020 part 2 - Remove stale comment, fix assertion. r?tcampbell!

This likely hasn't been true for quite some time.

Depends on D129628

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1738020 part 3 - Change ReshapeForShadowedProp argument from JSObject to NativeObject. r?tcampbell!

Depends on D129629

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1738020 part 4 - Rename AddDataPropertyNonPrototype to AddDataPropertyToPlainObject. r?tcampbell!

The "NonPrototype" in the name no longer matteres, because shape teleporting is now
handled by addProperty which we end up calling.

Depends on D129630

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1738020 part 5 - Move ReshapeForProtoMutation call to JSObject::setProtoUnchecked. r?tcampbell!

Merge SetProto into JSObject::setProtoUnchecked. This is similar to part 1.

Depends on D129631

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c241731c330
part 1 - Check for shadowing properties from addProperty and addCustomDataProperty. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/52c2ad00c45c
part 2 - Remove stale comment, fix assertion. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/56d9473b398c
part 3 - Change ReshapeForShadowedProp argument from JSObject to NativeObject. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/14e58099684f
part 4 - Rename AddDataPropertyNonPrototype to AddDataPropertyToPlainObject. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/45630b70f1fd
part 5 - Move ReshapeForProtoMutation call to JSObject::setProtoUnchecked. r=tcampbell

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/4c241731c330
https://hg.mozilla.org/mozilla-central/rev/52c2ad00c45c
https://hg.mozilla.org/mozilla-central/rev/56d9473b398c
https://hg.mozilla.org/mozilla-central/rev/14e58099684f
https://hg.mozilla.org/mozilla-central/rev/45630b70f1fd