1738032 - Push initial states to the cache and update using events

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

In the initial cache push, we need to include states. We can then keep this up to date using state change events, since they include all the necessary info.

This isn't going to be perfect initially because some of our state change events are flawed, which is being addressed in bug 1733188. On the other hand, lack of any state support makes progress in some areas difficult on Windows; e.g. links can't be reported, editable text can't be recognised, etc.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1738032 part 1: Support uint64_t as a value type for AccAttributes.

Comment 2

[James Teh [:Jamie]]

Attachment: Bug 1738032 part 2: Push a11y state in the initial cache push.

Rather than cache updates thereafter, state will be kept up to date using state change events.

Comment 3

[James Teh [:Jamie]]

Attachment: Bug 1738032 part 3: Move LocalAccessible::State to Accessible.

This patch includes XPCOM support.
Unfortunately, LocalAccessible::State isn't const, so the base method can't be const for now either.

Comment 4

[James Teh [:Jamie]]

Attachment: Bug 1738032 part 4: Use the cache for RemoteAccessible state.

Comment 5

[James Teh [:Jamie]]

Attachment: Bug 1738032 part 5: Use the unified Accessible::State on Windows to support cached RemoteAccessible.

Comment 6

[James Teh [:Jamie]]

Attachment: Bug 1738032 part 6: browser_caching_states.js: Ignore state changes for states we aren't interested in.

For example, when disabling an HTML input, we get an event for SUPPORTS_AUTOCOMPLETION among others.
If we continue with the test after that state change and there hasn't been an ENABLED/UNAVAILABLE state change, the cache won't be up to date.
Unfortunately, we can't use untilCacheOk here because we don't do a cache push for state changes.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aea47dd76bc9
part 1: Support uint64_t as a value type for AccAttributes. r=eeejay
https://hg.mozilla.org/integration/autoland/rev/da55cab72787
part 2: Push a11y state in the initial cache push. r=eeejay
https://hg.mozilla.org/integration/autoland/rev/3b7dd1588920
part 3: Move LocalAccessible::State to Accessible. r=eeejay
https://hg.mozilla.org/integration/autoland/rev/6d715aea99bf
part 4: Use the cache for RemoteAccessible state. r=eeejay
https://hg.mozilla.org/integration/autoland/rev/a3b8dd0dbe3c
part 5: Use the unified Accessible::State on Windows to support cached RemoteAccessible. r=morgan
https://hg.mozilla.org/integration/autoland/rev/f07c7d4ac124
part 6: browser_caching_states.js: Ignore state changes for states we aren't interested in. r=eeejay

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/aea47dd76bc9
https://hg.mozilla.org/mozilla-central/rev/da55cab72787
https://hg.mozilla.org/mozilla-central/rev/3b7dd1588920
https://hg.mozilla.org/mozilla-central/rev/6d715aea99bf
https://hg.mozilla.org/mozilla-central/rev/a3b8dd0dbe3c
https://hg.mozilla.org/mozilla-central/rev/f07c7d4ac124