Closed Bug 1738097 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31403 - Reland "[LCP] Add animated image support"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox95 fixed)

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31403 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31403
Details from upstream follow.

Yoav Weiss <yoavweiss@chromium.org> wrote:

Reland "[LCP] Add animated image support"

This is a reland of b7d510c06e0436cfb4bd7260175cd460b949225c

Original change's description:

[LCP] Add animated image support

This CL adds support for better handling of animated images in LCP:

  • A new attribute is exposing the first animated frame's paint time
    (behind a flag).
  • startTime is not changed.
  • The PageLoadMetrics reported for LCP are set to that first frame paint
    time for animated images (behind another flag).
  • Entries are not emitted until the image is loaded.

Relevant spec issue:
https://github.com/WICG/largest-contentful-paint/issues/83

Change-Id: I6bb01eacb4f200f9c032ffcfcd9a1a41126a7773
Bug: 1260953
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226157
Commit-Queue: Yoav Weiss \<yoavweiss@chromium.org>
Reviewed-by: Nicolás Peña Moreno \<npm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#935133}

Bug: 1260953
Change-Id: I5eaaf0cfd1daa7fb905e68aed4994cb931dc7750

Reviewed-on: https://chromium-review.googlesource.com/3247449
WPT-Export-Revision: 91141d8391d829a5cbe6a6e2cd6ed8b8b95531d3

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 30 tests and 1 subtests

Status Summary

Firefox

OK : 30
FAIL: 30

Chrome

OK : 30
PASS: 22
FAIL: 8

Safari

OK : 30
FAIL: 30

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/largest-contentful-paint/animated/observe-animated-image-gif.tentative.html
Same origin animated image is observable and has a first frame.: FAIL (Chrome: FAIL, Safari: FAIL)
/largest-contentful-paint/contracted-image.html
Largest Contentful Paint: |size| attribute is bounded by display size.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/animated/observe-animated-image-webp.tentative.html
Same origin animated image is observable and has a first frame.: FAIL (Chrome: FAIL, Safari: FAIL)
/largest-contentful-paint/cross-origin-image.sub.html
Cross-origin image is observable, with renderTime equal to 0.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/animated/observe-animated-image.tentative.html
Same origin animated image is observable and has a first frame.: FAIL (Chrome: FAIL, Safari: FAIL)
/largest-contentful-paint/expanded-image.html
Largest Contentful Paint: |size| attribute is bounded by intrinsic size.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/animated/observe-cross-origin-animated-image.tentative.html
Same origin animated image is observable and has a first frame.: FAIL (Chrome: FAIL, Safari: FAIL)
/largest-contentful-paint/first-letter-background.html
Largest Contentful Paint: first-letter is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/animated/observe-cross-origin-tao-animated-image.tentative.html
Same origin animated image is observable and has a first frame.: FAIL (Chrome: FAIL, Safari: FAIL)
/largest-contentful-paint/image-TAO.sub.html
Cross-origin elements with valid TAO have correct renderTime, with invalid TAO have renderTime set to 0.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/animated/observe-non-animated-image.tentative.html
Same origin animated image is observable and has a first frame.: FAIL (Chrome: FAIL, Safari: FAIL)
/largest-contentful-paint/image-full-viewport.html
The intersectionRect of an img element overflowing is computed correctly: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/image-inside-svg.html
Image inside SVG is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/image-not-fully-visible.html
The intersectionRect of an img element overflowing is computed correctly: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/image-removed-before-load.html
Largest Contentful Paint: image removed before loaded does not produce entry.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/image-src-change.html
Largest Contentful Paint: changing src causes a new entry to be dispatched.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/larger-image.html
Largest Contentful Paint: largest image is reported.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/loadTime-after-appendChild.html
Image loadTime occurs after appendChild is called.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/multiple-redirects-TAO.html
Cross-origin images with passing/failing TAO should/shouldn't have its renderTime set.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/observe-after-untrusted-scroll.html
Same-origin image after a JS initiated scroll event is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/observe-image.html
Same-origin image is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/observe-svg-background-image.html
Same-origin SVG background image is observable.: FAIL (Chrome: FAIL, Safari: FAIL)
/largest-contentful-paint/observe-svg-data-uri-background-image.html
Data-URI background SVG image is observable.: FAIL (Chrome: FAIL, Safari: FAIL)
/largest-contentful-paint/observe-svg-data-uri-image.html
Same-origin image is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/observe-svg-image.html
Same-origin image is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/placeholder-image.html
Largest Contentful Paint: changing src causes a new entry to be dispatched.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/redirects-tao-star.html
Cross-origin image without TAO should not have its renderTime set, with full TAO it should.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/repeated-image.html
Repeated image produces different timestamps.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/same-origin-redirects.html
Same-origin image redirect without TAO should have its renderTime set.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/video-poster.html
Able to observe a video's poster image.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bdfe4a78e6ac
[wpt PR 31403] - Reland "[LCP] Add animated image support", a=testonly

https://hg.mozilla.org/mozilla-central/rev/bdfe4a78e6ac

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.