Closed Bug 1738121 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31404 - Use gfx::RectF for LayoutSVGImage::object_bounding_box_

Categories

(Core :: SVG, task, P4)

Product:
Core
Component:
SVG
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox96 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31404 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31404
Details from upstream follow.

Xianzhu Wang <wangxianzhu@chromium.org> wrote:

Use gfx::RectF for LayoutSVGImage::object_bounding_box_

This CL changes the result of LayoutSVGImage::ObjectBoundingBox() and
SVGImageElement::getBBox() when the width or height is negative,
which is expected as we have already been doing this for other SVG
shapes (tests included).

Bug: 738465
Change-Id: Id6afda3c7981c6151e2b8f36a41c18aac6e06d9e

Reviewed-on: https://chromium-review.googlesource.com/3248891
WPT-Export-Revision: 307399ec9600cc36f359b25ca51b5de03c10966d

Component: web-platform-tests → SVG
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 10 subtests

Status Summary

Firefox

OK : 1
PASS: 1
FAIL: 9

Chrome

OK : 1
FAIL: 10

Safari

OK : 1
PASS: 3
FAIL: 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/svg/types/scripted/SVGGraphicsElement.getBBox-03.html
rect1: FAIL (Chrome: FAIL, Safari: FAIL)
rect2: FAIL (Chrome: FAIL, Safari: FAIL)
circle: FAIL (Chrome: FAIL, Safari: FAIL)
ellipse1: FAIL (Chrome: FAIL, Safari: FAIL)
ellipse2: FAIL (Chrome: FAIL, Safari: FAIL)
image3: FAIL (Chrome: FAIL, Safari: PASS)
image4: FAIL (Chrome: FAIL, Safari: PASS)
foreign1: FAIL (Chrome: FAIL, Safari: FAIL)
foreign2: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f5dac00e49fd [wpt PR 31404] - Fix SVGGraphicsElement.getBBox() when width or height is negative, a=testonly https://hg.mozilla.org/integration/autoland/rev/22d005c9b30d [wpt PR 31404] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f5dac00e49fd
https://hg.mozilla.org/mozilla-central/rev/22d005c9b30d

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.