Implement nsIPop3IncomingServer in JavaScript
Categories
(MailNews Core :: Networking: POP, task)
Tracking
(thunderbird_esr91 wontfix)
Tracking | Status | |
---|---|---|
thunderbird_esr91 | --- | wontfix |
People
(Reporter: rnons, Assigned: rnons)
References
Details
Attachments
(11 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
Assignee | ||
Updated•7 months ago
|
Assignee | ||
Comment 1•6 months ago
|
||
Also implement clearAllValues/removeFiles in MsgIncomingServer, creating/removing POP3 account works.
Assignee | ||
Comment 2•6 months ago
|
||
Depends on D131029.
Assignee | ||
Updated•6 months ago
|
Updated•6 months ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/cba7e1992148
Implement nsILocalMailIncomingServer in Pop3IncomingServer.jsm. r=mkmelin
https://hg.mozilla.org/comm-central/rev/2261682906df
Enable test_localFolder.js for pop3-js. r=mkmelin
Assignee | ||
Comment 4•5 months ago
|
||
Assignee | ||
Comment 5•5 months ago
|
||
Depends on D133726.
Assignee | ||
Updated•5 months ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/3bce321f84b7
Enable test_pop3Download.js for pop3-js. r=mkmelin
https://hg.mozilla.org/comm-central/rev/4576d01342e1
Enable test_pop3Duplicates.js for pop3-js.r=mkmelin
Assignee | ||
Comment 7•5 months ago
|
||
Depends on D134370.
Updated•5 months ago
|
Assignee | ||
Updated•5 months ago
|
Should that !/^[\x00-\xFF]+$/.test(password)
test also go here?
https://searchfox.org/comm-central/rev/64bc43d503090f21dad346cfb9c6907350114f58/mailnews/compose/src/SmtpClient.jsm#980
BTW, originally in bug 1500772 the reporter complained about ä and § which are "latin1".
Assignee | ||
Comment 9•5 months ago
|
||
(In reply to newsfan from comment #8)
Should that
!/^[\x00-\xFF]+$/.test(password)
test also go here?
https://searchfox.org/comm-central/rev/64bc43d503090f21dad346cfb9c6907350114f58/mailnews/compose/src/SmtpClient.jsm#980
I think I already did this in D134483. Or do you mean I should not?
BTW, originally in bug 1500772 the reporter complained about ä and § which are "latin1".
Yes, that's why the pref is still needed. If the password only contains latin1, the behavior is controlled by the pref. If not, btoa won't work anyway, so we convert it to binary string first and hope it works.
btoa('ä')
// "5A=="
btoa(String.fromCharCode(...new TextEncoder().encode('ä')))
// "w6Q="
Comment 10•5 months ago
|
||
Apologies, the patch covers both SMTP and POP3, I should pay more attention before commenting. All good.
Comment 11•5 months ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/4c3de57813e1
Enable test_pop3GetNewMail for pop3-js. r=mkmelin
Comment 12•5 months ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/0805456805e0 follow-up - fix linting. rs=eslint DONTBUILD
Assignee | ||
Comment 13•4 months ago
|
||
Assignee | ||
Updated•4 months ago
|
Comment 14•4 months ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/5435207bdb08
Implement missing interfaces in MsgIncomingServer.js. r=mkmelin
Assignee | ||
Comment 15•4 months ago
|
||
downloadMailFromServers is used to get new messages on startup.
Depends on D135588.
Assignee | ||
Updated•4 months ago
|
Assignee | ||
Comment 16•4 months ago
|
||
Depends on D135589.
Assignee | ||
Comment 17•4 months ago
|
||
Depends on D135671.
Comment 18•4 months ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/46b286138346
Implement downloadMailFromServers in Pop3IncomingServer.jsm. r=mkmelin
https://hg.mozilla.org/comm-central/rev/671c05bafd5d
Implement addUidlToMark and markMessages in Pop3IncomingServer.jsm. r=mkmelin
https://hg.mozilla.org/comm-central/rev/b63099f26327
Implement performBiff in Pop3IncomingServer.jsm. r=mkmelin
Assignee | ||
Comment 19•4 months ago
|
||
Comment 20•4 months ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/08912124f94d Fix getEditableFilterList so that filters dialog works with pop3-js. r=mkmelin
Assignee | ||
Comment 21•4 months ago
|
||
Assignee | ||
Updated•4 months ago
|
Comment 22•4 months ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/a5228055d6e0
Prevent infinite loop in rootMsgFolder getter in Pop3IncomingServer.jsm. r=mkmelin
Assignee | ||
Updated•3 months ago
|
Description
•