1738174 - Implement nsIPop3IncomingServer in JavaScript

Status: RESOLVED FIXED

(MailNews Core :: Networking: POP, task)

Comment 1

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738174 - Implement nsILocalMailIncomingServer in Pop3IncomingServer.jsm. r=mkmelin

Also implement clearAllValues/removeFiles in MsgIncomingServer, creating/removing POP3 account works.

Comment 2

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738174 - Enable test_localFolder.js for pop3-js. r=mkmelin

Depends on D131029.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cba7e1992148
Implement nsILocalMailIncomingServer in Pop3IncomingServer.jsm. r=mkmelin
https://hg.mozilla.org/comm-central/rev/2261682906df
Enable test_localFolder.js for pop3-js. r=mkmelin

Comment 4

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738174 - Enable test_pop3Download.js for pop3-js. r=mkmelin

Comment 5

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738174 - Enable test_pop3Duplicates.js for pop3-js.r=mkmelin

Depends on D133726.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3bce321f84b7
Enable test_pop3Download.js for pop3-js. r=mkmelin
https://hg.mozilla.org/comm-central/rev/4576d01342e1
Enable test_pop3Duplicates.js for pop3-js.r=mkmelin

Comment 7

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738174 - Enable test_pop3GetNewMail for pop3-js. r=mkmelin

Depends on D134370.

Comment 8

[newsfan]

Should that !/^[\x00-\xFF]+$/.test(password) test also go here?
https://searchfox.org/comm-central/rev/64bc43d503090f21dad346cfb9c6907350114f58/mailnews/compose/src/SmtpClient.jsm#980

BTW, originally in bug 1500772 the reporter complained about ä and § which are "latin1".

Comment 9

[Ping Chen [:rnons] (away)]

(In reply to newsfan from comment #8)

Should that !/^[\x00-\xFF]+$/.test(password) test also go here?
https://searchfox.org/comm-central/rev/64bc43d503090f21dad346cfb9c6907350114f58/mailnews/compose/src/SmtpClient.jsm#980

I think I already did this in D134483. Or do you mean I should not?

BTW, originally in bug 1500772 the reporter complained about ä and § which are "latin1".

Yes, that's why the pref is still needed. If the password only contains latin1, the behavior is controlled by the pref. If not, btoa won't work anyway, so we convert it to binary string first and hope it works.

btoa('ä')
// "5A=="
btoa(String.fromCharCode(...new TextEncoder().encode('ä')))
// "w6Q="

Comment 10

[newsfan]

Apologies, the patch covers both SMTP and POP3, I should pay more attention before commenting. All good.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4c3de57813e1
Enable test_pop3GetNewMail for pop3-js. r=mkmelin

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0805456805e0
follow-up - fix linting. rs=eslint DONTBUILD

Comment 13

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738174 - Implement missing interfaces in MsgIncomingServer.js. r=mkmelin

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5435207bdb08
Implement missing interfaces in MsgIncomingServer.js. r=mkmelin

Comment 15

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738174 - Implement downloadMailFromServers in Pop3IncomingServer.jsm. r=mkmelin

downloadMailFromServers is used to get new messages on startup.

Depends on D135588.

Comment 16

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738174 - Implement addUidlToMark and markMessages in Pop3IncomingServer.jsm. r=mkmelin

Depends on D135589.

Comment 17

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738174 - Implement performBiff in Pop3IncomingServer.jsm. r=mkmelin

Depends on D135671.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/46b286138346
Implement downloadMailFromServers in Pop3IncomingServer.jsm. r=mkmelin
https://hg.mozilla.org/comm-central/rev/671c05bafd5d
Implement addUidlToMark and markMessages in Pop3IncomingServer.jsm. r=mkmelin
https://hg.mozilla.org/comm-central/rev/b63099f26327
Implement performBiff in Pop3IncomingServer.jsm. r=mkmelin

Comment 19

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738174 - Fix getEditableFilterList so that filters dialog works with pop3-js. r=mkmelin

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/08912124f94d
Fix getEditableFilterList so that filters dialog works with pop3-js. r=mkmelin

Comment 21

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738174 - Prevent infinite loop in rootMsgFolder getter in Pop3IncomingServer.jsm. r=mkmelin

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a5228055d6e0
Prevent infinite loop in rootMsgFolder getter in Pop3IncomingServer.jsm. r=mkmelin