Closed Bug 1738174 Opened 7 months ago Closed 3 months ago

Implement nsIPop3IncomingServer in JavaScript

Categories

(MailNews Core :: Networking: POP, task)

Tracking

(thunderbird_esr91 wontfix)

RESOLVED FIXED
96 Branch
Tracking Status
thunderbird_esr91 --- wontfix

People

(Reporter: rnons, Assigned: rnons)

References

Details

Attachments

(11 files)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
No description provided.
Assignee: nobody → remotenonsense
Status: NEW → ASSIGNED

Also implement clearAllValues/removeFiles in MsgIncomingServer, creating/removing POP3 account works.

Depends on D131029.

Target Milestone: --- → 96 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/cba7e1992148
Implement nsILocalMailIncomingServer in Pop3IncomingServer.jsm. r=mkmelin
https://hg.mozilla.org/comm-central/rev/2261682906df
Enable test_localFolder.js for pop3-js. r=mkmelin

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/3bce321f84b7
Enable test_pop3Download.js for pop3-js. r=mkmelin
https://hg.mozilla.org/comm-central/rev/4576d01342e1
Enable test_pop3Duplicates.js for pop3-js.r=mkmelin

Depends on D134370.

Attachment #9256500 - Attachment description: Bug 1738174 - Enable test_pop3GetNewMail for nntp-js. r=mkmelin → Bug 1738174 - Enable test_pop3GetNewMail for pop3-js. r=mkmelin

Should that !/^[\x00-\xFF]+$/.test(password) test also go here?
https://searchfox.org/comm-central/rev/64bc43d503090f21dad346cfb9c6907350114f58/mailnews/compose/src/SmtpClient.jsm#980

BTW, originally in bug 1500772 the reporter complained about ä and § which are "latin1".

(In reply to newsfan from comment #8)

Should that !/^[\x00-\xFF]+$/.test(password) test also go here?
https://searchfox.org/comm-central/rev/64bc43d503090f21dad346cfb9c6907350114f58/mailnews/compose/src/SmtpClient.jsm#980

I think I already did this in D134483. Or do you mean I should not?

BTW, originally in bug 1500772 the reporter complained about ä and § which are "latin1".

Yes, that's why the pref is still needed. If the password only contains latin1, the behavior is controlled by the pref. If not, btoa won't work anyway, so we convert it to binary string first and hope it works.

btoa('ä')
// "5A=="
btoa(String.fromCharCode(...new TextEncoder().encode('ä')))
// "w6Q="

Apologies, the patch covers both SMTP and POP3, I should pay more attention before commenting. All good.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/4c3de57813e1
Enable test_pop3GetNewMail for pop3-js. r=mkmelin

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/0805456805e0
follow-up - fix linting. rs=eslint DONTBUILD

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/5435207bdb08
Implement missing interfaces in MsgIncomingServer.js. r=mkmelin

downloadMailFromServers is used to get new messages on startup.

Depends on D135588.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/46b286138346
Implement downloadMailFromServers in Pop3IncomingServer.jsm. r=mkmelin
https://hg.mozilla.org/comm-central/rev/671c05bafd5d
Implement addUidlToMark and markMessages in Pop3IncomingServer.jsm. r=mkmelin
https://hg.mozilla.org/comm-central/rev/b63099f26327
Implement performBiff in Pop3IncomingServer.jsm. r=mkmelin

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/08912124f94d
Fix getEditableFilterList so that filters dialog works with pop3-js. r=mkmelin

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/a5228055d6e0
Prevent infinite loop in rootMsgFolder getter in Pop3IncomingServer.jsm. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Keywords: leave-open
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.