Closed Bug 1738239 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31415 - Reland #2 "[LCP] Add animated image support"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox96 fixed)

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox96 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31415 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31415
Details from upstream follow.

Yoav Weiss <yoavweiss@chromium.org> wrote:

Reland #2 "[LCP] Add animated image support"

This is a manual reland of
https://chromium-review.googlesource.com/c/chromium/src/+/3247449

The difference from the previous reland is that the browser tests now
include 2 separate timeouts and a double rAF, to ensure that the
presentation timestamp taken is far enough from both the time the first
frame is sent as well as from the time the second frame is sent.

Original change's description:

[LCP] Add animated image support

This CL adds support for better handling of animated images in LCP:

  • A new attribute is exposing the first animated frame's paint time
    (behind a flag).
  • startTime is not changed.
  • The PageLoadMetrics reported for LCP are set to that first frame paint
    time for animated images (behind another flag).
  • Entries are not emitted until the image is loaded.

Relevant spec issue:
https://github.com/WICG/largest-contentful-paint/issues/83

Bug: 1260953
Change-Id: I34070bd90a74ed44281da63b547f13d9669f389b

Reviewed-on: https://chromium-review.googlesource.com/3250690
WPT-Export-Revision: a557e8ead77b9e43e7958e45e1d2adf45828ee0e

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 30 tests and 1 subtests

Status Summary

Firefox

OK : 30
FAIL: 30

Chrome

OK : 30
PASS: 22
FAIL: 8

Safari

OK : 30
FAIL: 30

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/largest-contentful-paint/animated/observe-animated-image-gif.tentative.html
Same origin animated image is observable and has a first frame.: FAIL (Chrome: FAIL, Safari: FAIL)
/largest-contentful-paint/animated/observe-animated-image-webp.tentative.html
Same origin animated image is observable and has a first frame.: FAIL (Chrome: FAIL, Safari: FAIL)
/largest-contentful-paint/animated/observe-animated-image.tentative.html
Same origin animated image is observable and has a first frame.: FAIL (Chrome: FAIL, Safari: FAIL)
/largest-contentful-paint/animated/observe-cross-origin-animated-image.tentative.html
Same origin animated image is observable and has a first frame.: FAIL (Chrome: FAIL, Safari: FAIL)
/largest-contentful-paint/animated/observe-cross-origin-tao-animated-image.tentative.html
Same origin animated image is observable and has a first frame.: FAIL (Chrome: FAIL, Safari: FAIL)
/largest-contentful-paint/animated/observe-non-animated-image.tentative.html
Same origin animated image is observable and has a first frame.: FAIL (Chrome: FAIL, Safari: FAIL)
/largest-contentful-paint/contracted-image.html
Largest Contentful Paint: |size| attribute is bounded by display size.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/cross-origin-image.sub.html
Cross-origin image is observable, with renderTime equal to 0.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/expanded-image.html
Largest Contentful Paint: |size| attribute is bounded by intrinsic size.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/first-letter-background.html
Largest Contentful Paint: first-letter is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/image-TAO.sub.html
Cross-origin elements with valid TAO have correct renderTime, with invalid TAO have renderTime set to 0.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/image-full-viewport.html
The intersectionRect of an img element overflowing is computed correctly: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/image-inside-svg.html
Image inside SVG is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/image-not-fully-visible.html
The intersectionRect of an img element overflowing is computed correctly: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/image-removed-before-load.html
Largest Contentful Paint: image removed before loaded does not produce entry.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/image-src-change.html
Largest Contentful Paint: changing src causes a new entry to be dispatched.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/larger-image.html
Largest Contentful Paint: largest image is reported.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/loadTime-after-appendChild.html
Image loadTime occurs after appendChild is called.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/multiple-redirects-TAO.html
Cross-origin images with passing/failing TAO should/shouldn't have its renderTime set.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/observe-after-untrusted-scroll.html
Same-origin image after a JS initiated scroll event is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/observe-image.html
Same-origin image is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/observe-svg-background-image.html
Same-origin SVG background image is observable.: FAIL (Chrome: FAIL, Safari: FAIL)
/largest-contentful-paint/observe-svg-data-uri-background-image.html
Data-URI background SVG image is observable.: FAIL (Chrome: FAIL, Safari: FAIL)
/largest-contentful-paint/observe-svg-data-uri-image.html
Same-origin image is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/observe-svg-image.html
Same-origin image is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/placeholder-image.html
Largest Contentful Paint: changing src causes a new entry to be dispatched.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/redirects-tao-star.html
Cross-origin image without TAO should not have its renderTime set, with full TAO it should.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/repeated-image.html
Repeated image produces different timestamps.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/same-origin-redirects.html
Same-origin image redirect without TAO should have its renderTime set.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/video-poster.html
Able to observe a video's poster image.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/99c97230d1c4 [wpt PR 31415] - Reland #2 "[LCP] Add animated image support", a=testonly https://hg.mozilla.org/integration/autoland/rev/59c7159be457 [wpt PR 31415] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/99c97230d1c4
https://hg.mozilla.org/mozilla-central/rev/59c7159be457

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.