1738245 - Remove OS.File usage from various browser/ tests

Status: RESOLVED FIXED

(Firefox :: General, task, P3)

Description

[Mark Banner (:standard8)]

Using OS.File for file access is now obsolete and can be replaced by code using IOUtils. Working towards this, in this bug we want remove all OS.File usage from these files:

• browser/base/content/test/static/browser_all_files_referenced.js
• browser/components/downloads/test/unit/test_DownloadsCommon_getMimeInfo.js
• browser/components/extensions/test/browser/browser_ext_tabs_saveAsPDF.js
• browser/components/migration/tests/unit/test_Chrome_bookmarks.js
• browser/components/migration/tests/unit/test_MigrationUtils_timedRetry.js

The code in question can be found here.

There is background information here about how to migrate from OS.File to IOUtils. If you have questions, please ask.

To run the tests after you've built, you can run ./mach test path/to/file. You should also check ESLint before commiting: ./mach eslint browser/.

I'm happy to mentor this. Note this bug will be auto-assigned when the first patch is attached, but feel free to comment that you're working on it.

Comment 1

[[e-mail]]

I'd love to give this a try but I'm running into a few errors during tests, can I submit my patch?

Comment 2

[Mark Banner (:standard8)]

Yes, it is always fine to post patches which are work in progress to get feedback - just make it clear that's what you are doing.

Comment 3

[[e-mail]]

Attachment: Bug 1738245 - Remove OS.File usage from various browser/ tests. r?standard8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a045ce98e572
Remove OS.File usage from various browser/ tests. r=Standard8,robwu

Comment 5

[Marian-Vasile Laza]

Backed out changeset a045ce98e572 (Bug 1738245) for causing xpcshell failures on test_MigrationUtils_timedRetry.js.
Backout link
Push with failures
Failure Log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa33b5ca2b96
Remove OS.File usage from various browser/ tests. r=Standard8,robwu

Comment 7

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/aa33b5ca2b96