1738264 - The Open Previous Tabs Infobar is displayed on a Private Browsing window

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect)

Description

[Simona Badau, Desktop QA]

Attachment: Screenshot with the issue

Affected platforms:
Windows 10 x64
Windows 7x64
Ubuntu 20.04 x64

Affected versions:
Firefox 94
Nightly 95.0a1

Pre-requisites:

• pin Firefox to the taskbar/dock.

Steps to reproduce:

1. Launch Firefox with a new profile.
2. Open a few tabs on various sites.
3. Close Firefox.
4. Open Firefox in a private window - right-click the icon in the taskbar and select "New private window".

Expected Results:
The "Open Previous Tabs" Infobar should not be displayed as the "Restore Previous Session" option is grayed out in Private Browsing mode.

Actual Results:
The "Open Previous Tabs" Infobar is displayed.

Notes:
On Ubuntu 20.04 reproduced the issue on the canonical Firefox versions (I could only add these versions to the dock as Favorites).

Comment 1

[Adrian Florinescu [:aflorinescu]]

The above scenario also reproduces with switching from normal mode to persistent private mode (-private startup argument): if first time you go from a multitab normal session to a private session it will be showing the infobar modal, which is not optimal in terms of showing users that they don't have any session to be restored.

Comment 2

[Romain Testard [:RT]]

Since this does not reproduce for users who run in PBM always (set through History settings - this is a user population that is significant) I'm marking as 'won't fix' for 94 (the user population affected is really small per STR).
I don't see it as a blocker for 95 given that most users would have already seen this one time message anyway and the target population would be even smaller as a consequence.

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1738264 - don't show session restore infobar for private browsing windows, r?sfoster

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59d5470c86c9
don't show session restore infobar for private browsing windows, r=sfoster

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/59d5470c86c9

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Did you want to uplift this to 95?

Comment 7

[:Gijs (he/him)]

Comment on attachment 9248520 [details]
Bug 1738264 - don't show session restore infobar for private browsing windows, r?sfoster

Beta/Release Uplift Approval Request

• User impact if declined: Useless notification bar
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0
• List of other uplifts needed: no
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very tiny JS-only change that only affects this notification bar
• String changes made/needed: Nope

Comment 8

[Simona Badau, Desktop QA]

Verified as fixed using the latest Nightly 96.0a1 on Windows 10 x64 and Windows 7 x64.

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9248520 [details]
Bug 1738264 - don't show session restore infobar for private browsing windows, r?sfoster

Low risk, approved for our last 95 beta, thanks.

Comment 10

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/947e4d357a41

Comment 11

[Simona Badau, Desktop QA]

Verified as fixed on the latest Firefox 95 beta 12 on Windows 10 x64 and on Windows 7 x64.