Open Bug 1738298 Opened 4 years ago Updated 3 years ago

mozregression can't close Firefox on my machine | ERROR: Unable to stop the application (error: kill() got an unexpected keyword argument 'timeout')

Categories

(Testing :: mozregression, defect)

Default
defect

Tracking

(Not tracked)

People

(Reporter: mstange, Unassigned)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [fixed by 1714529][no-nag])

Steps to reproduce:

  1. Be on macOS 12 and have mozregression 4.0.18 installed.
  2. Start a bisection with mozregression --bad 2021-10-05.
  3. After a Firefox build has started, type "good" or "bad".

Expected results:
Firefox should close.

Actual results:
The Firefox app stays open, and the following is printed to the console by mozregression:

15:12.24 ERROR: Unable to stop the application (error: kill() got an unexpected keyword argument 'timeout')

I installed mozregression using the pip3 command. python3 --version gives Python 3.9.7.

Could you please paste the output of python3 -m pip show mozrunner mozprocess?

Flags: needinfo?(mstange.moz)
% python3 -m pip show mozrunner mozprocess
Name: mozrunner
Version: 8.2.0
Summary: Reliable start/stop/configuration of Mozilla Applications (Firefox, Thunderbird, etc.)
Home-page: https://wiki.mozilla.org/Auto-tools/Projects/Mozbase
Author: Mozilla Automation and Tools team
Author-email: tools@lists.mozilla.org
License: MPL 2.0
Location: /opt/homebrew/lib/python3.9/site-packages
Requires: mozdevice, mozfile, mozinfo, mozlog, mozprocess, mozprofile, six
Required-by: mozregression
---
Name: mozprocess
Version: 1.2.1
Summary: Mozilla-authored process handling
Home-page: https://wiki.mozilla.org/Auto-tools/Projects/Mozbase
Author: Mozilla Automation and Tools team
Author-email: tools@lists.mozilla.org
License: MPL 2.0
Location: /opt/homebrew/lib/python3.9/site-packages
Requires: mozinfo
Required-by: mozregression, mozrunner
Flags: needinfo?(mstange.moz)

Thanks! I can reproduce with those versions.
So I think this is just an incompatibility between mozrunner>=8.2.0 and mozprocess<=1.3.0 due to only one having the changes in bug 1705385, caused by a release of mozrunner (bug 1713307) not being synced with a release of mozprocess, which was then rectified in bug 1714529.
So if you upgrade mozprocess (or mozrunner, since the dep should upgrade mozprocess at the same time) it should work again.

Depends on: 1714529
Regressed by: 1713307
See Also: → 1705385
Whiteboard: [fixed by 1714529]

Shhhh bot.

Flags: needinfo?(wlachance)
Whiteboard: [fixed by 1714529] → [fixed by 1714529][no-nag]

I had exactly the same problem on Linux. Running the command pip install mozrunner --upgrade fixed the issue indeed.

OS: macOS → All
Hardware: ARM64 → All
Summary: mozregression can't close Firefox on my macOS machine | ERROR: Unable to stop the application (error: kill() got an unexpected keyword argument 'timeout') → mozregression can't close Firefox on my machine | ERROR: Unable to stop the application (error: kill() got an unexpected keyword argument 'timeout')
You need to log in before you can comment on or make changes to this bug.