1738310 - Some minor code improvements for aboutLogin components

Status: RESOLVED FIXED

(Firefox :: about:logins, task, P3)

Description

[Dimi Lee [:dimi]]

I took a quick look around aboutLoginChild/aboutLoginParent/aboutLoginsUtils to see if I have any idea what refactoring work could be done, unfortunately, I don't have any good idea at this moment.
However, the are some quite minor coding style changes we can do

• aboutLoginChild.jsm
  • The naming of the message can be changed to match the function name to better reflect its real usage
    https://searchfox.org/mozilla-central/rev/a9e0a3f5e5f7cde941d419db967997aaa1f06b0f/browser/components/aboutlogins/AboutLoginsChild.jsm#211-225
  • add 'g' prefix to the global variable
    https://searchfox.org/mozilla-central/rev/a9e0a3f5e5f7cde941d419db967997aaa1f06b0f/browser/components/aboutlogins/AboutLoginsChild.jsm#33-35
• aboutLoginParent.jsm
  • add 'g' prefix to the variable and give it a default value.
    https://searchfox.org/mozilla-central/rev/a9e0a3f5e5f7cde941d419db967997aaa1f06b0f/browser/components/aboutlogins/AboutLoginsParent.jsm#68
  • move the magic const value to the top of the file like the other const variables for readibility
    https://searchfox.org/mozilla-central/rev/a9e0a3f5e5f7cde941d419db967997aaa1f06b0f/browser/components/aboutlogins/AboutLoginsParent.jsm#229
• aboutLoginsUtils.js
  • use optional chaining to simplify the expressions
    https://searchfox.org/mozilla-central/rev/a9e0a3f5e5f7cde941d419db967997aaa1f06b0f/browser/components/aboutlogins/content/aboutLoginsUtils.js#32

Comment 1

[Tim Giles [:tgiles]]

Attachment: Bug 1738310 - Refactor parts of aboutlogins to be more understandable. r=sgalich

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d06d7c8f16d
Refactor parts of aboutlogins to be more understandable. r=sgalich

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/7d06d7c8f16d