Closed Bug 1738429 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31436 - Include block-start ruby annotations when block-fragmenting.

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox96 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31436 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31436
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Include block-start ruby annotations when block-fragmenting.

The block-offset of a line box with ruby annotations may have been
increased to make room for the annotations above. Take this into account
when determining whether to break before a line. If the line (including
ruby annotations) is at the block-start of the fragmentainer, we cannot
break before it, as that would prevent content progress, and we'd get
stuck in an infinite loop, retrying to place the line in subsequent
fragmentainers, when the fragmentainers aren't tall enough.

Bug: 1253341
Change-Id: I14a5eee3f3b4da6a9bcd5efc664344354755ed55
Reviewed-on: https://chromium-review.googlesource.com/3250830
WPT-Export-Revision: 75e3359606ead8490559f58055407a703273be05

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-break/ruby-003.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/64a7ecf9f475 [wpt PR 31436] - Include block-start ruby annotations when block-fragmenting., a=testonly https://hg.mozilla.org/integration/autoland/rev/18fe2f9bcfb0 [wpt PR 31436] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/64a7ecf9f475
https://hg.mozilla.org/mozilla-central/rev/18fe2f9bcfb0

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.